From 3bb8ca8ff712521d241f28d75e98a2034d23c49c Mon Sep 17 00:00:00 2001 From: Gian Merlino Date: Wed, 10 Nov 2021 17:58:23 -0800 Subject: [PATCH] Fix incorrect comparison in RowSignature. PR #11882 introduced a type comparison using ==, but while it was in flight, another PR #11713 changed the type enum to a class. So the comparison should properly be done with "equals". --- .../main/java/org/apache/druid/segment/column/RowSignature.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/processing/src/main/java/org/apache/druid/segment/column/RowSignature.java b/processing/src/main/java/org/apache/druid/segment/column/RowSignature.java index 10386224fd94..77794bb8c797 100644 --- a/processing/src/main/java/org/apache/druid/segment/column/RowSignature.java +++ b/processing/src/main/java/org/apache/druid/segment/column/RowSignature.java @@ -277,7 +277,7 @@ public Builder addAggregators(final List aggregators, final F default: assert finalization == Finalization.UNKNOWN; - if (aggregator.getType() == aggregator.getFinalizedType()) { + if (aggregator.getType().equals(aggregator.getFinalizedType())) { type = aggregator.getType(); } else { // Use null if the type depends on whether the aggregator is finalized, since we don't know if