Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null handling bitmap performance #5569

Closed
gianm opened this issue Apr 3, 2018 · 6 comments
Closed

Null handling bitmap performance #5569

gianm opened this issue Apr 3, 2018 · 6 comments

Comments

@gianm
Copy link
Contributor

gianm commented Apr 3, 2018

I noticed that the null bitmap checks from #5278 are usually implemented like:

        public boolean isNull()
        {
          return nullValueBitmap.get(offset.getOffset());
        }

From what I recall, get on compressed bitmaps can be quite slow compared to walking an iterator.

@stale
Copy link

stale bot commented Jun 21, 2019

This issue has been marked as stale due to 280 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Jun 21, 2019
@gianm
Copy link
Contributor Author

gianm commented Jun 24, 2019

I believe this is still relevant.

@stale
Copy link

stale bot commented Jun 24, 2019

This issue is no longer marked as stale.

@stale stale bot removed the stale label Jun 24, 2019
@b-slim
Copy link
Contributor

b-slim commented Jun 24, 2019

@gianm any idea why a get with an offset is more expensive than walking iterator ?

@gianm
Copy link
Contributor Author

gianm commented Aug 1, 2019

@b-slim I'm not familiar with their implementation enough to know, but I could speculate. Perhaps the compressed bitmap iterators cache some information that needs to be re-computed if you are calling get repeatedly.

@gianm
Copy link
Contributor Author

gianm commented Apr 24, 2023

Fixed by #8822.

@gianm gianm closed this as completed Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants