[Managed Iceberg] bubble up exceptions due to writer close #32940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @kennknowles |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
kennknowles
approved these changes
Oct 25, 2024
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/RecordWriterManager.java
Show resolved
Hide resolved
|
Well, it would be good to have a test that confirms the exception makes it up to the top level. |
mravi
approved these changes
Oct 25, 2024
|
@kennknowles added a test, PTAL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guava's cache swallows removal listener exceptions, which may happen when a writer fails to close. This change will accumulate those suppressed exceptions and rethrow them later in the main thread.
We already fail the writer manager if any writer fails to close properly. This is more of a visibility/debugability issue, in trying to understand why the writer failed to close.