Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lab.antlr.org should reference grammars.json as a Github Actions artifact in gramamrs-v4 #52

Open
kaby76 opened this issue Nov 12, 2022 · 2 comments

Comments

@kaby76
Copy link
Collaborator

kaby76 commented Nov 12, 2022

People are grumbling that the indexer for grammars-v4 are checked into the repo. And, honestly, anything that is generated from the repo should be a Github Action Artifact. I will be changing the indexer to leave grammars-v4.json in the artifact area for the repo at some point. Once I change this, lab.antlr.org should use that. The main problem here is that there is no API to traverse the repo and tell what grammars are and their properties such as start symbol, targets, etc. grammars.json is the best solution for the moment. antlr/grammars-v4#2919

@parrt
Copy link
Member

parrt commented Nov 12, 2022

Do you mean that the index itself is checked in? Well I need something easy to reference from js via http so however you and Tom can make that happen it would be great! As long as I can do HTTP access to the artifact I'm happy.

I definitely don't think an http ref we should cause a traversal of the repository. That will be too slow and needs to be cached.

I understand about the merge conflict being a problem for that file...

@kaby76
Copy link
Collaborator Author

kaby76 commented Nov 28, 2022

Github now has "fine-grain personal access tokens" for read-only access to artifacts. It's in "beta", but it works. I'm now moving forward with changes in grammars-v4 to do the indexing but leave the result in an artifact. For now, grammars.json will still be accessible so that lab.antlr.org does not break. I will then update the client js code to download the zip file artifact that contains grammar.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants