Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cascader 组件官方示例在 Typescript 严格模式下类型报错 #43216

Closed
liaoyongfu opened this issue Jun 27, 2023 · 3 comments
Closed
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@liaoyongfu
Copy link

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Typescript "strict": true 模式下,onChange 类型不匹配

What is expected?

Typescript 下应该不报错。已经传递了自定义 Option 到 <Cascader 进去,理论上 onChange 第二个参数应该兼容才对

What is actually happening?

onChange 类型参数不匹配

Environment Info
antd 4.24.8
React 17
System win10
Browser Chrome
@zombieJ zombieJ added help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. and removed unconfirmed labels Jun 27, 2023
@github-actions
Copy link
Contributor

Hello @liaoyongfu. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @liaoyongfu,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@ZWkang
Copy link
Contributor

ZWkang commented Jun 27, 2023

看起来泛型参数应该透传一下 #43231 @zombieJ

@afc163
Copy link
Member

afc163 commented Jun 27, 2023

#43231

@afc163 afc163 closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

No branches or pull requests

4 participants