-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extra_vars format and empty value case #15232
base: devel
Are you sure you want to change the base?
Fix extra_vars format and empty value case #15232
Conversation
more broadly, is this a problem on awx api side, or unique to awx collection? i.e. even with these changes, is this still an issue with curl/awxkit |
Thank you. I think that awx_collection errors are expected since this is what the change is about. @fosterseth as far as I can see API expects yaml, so that's what we should give it through the collection. |
Quality Gate passedIssues Measures |
SUMMARY
For modules inventory, inventory_soruce, group, host and job_template
fixed
variable, extra_vars and source_vars parameters
so that modules while expecting dictionary as an input
push values in yaml format into AAP
Also, fixed edge case when user supplies empty dictionary so that yaml value being pushed into AAP is '---'
related #14918 #14842
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
Suggested testing.
(01) Create required objects with no variables/extra_vars
(02) Run the following (or similar) tasks
(03) Make sure that variables/extra_vars show right values and formatting in both yaml and json
(04) Run the following:
(05) Make sure that variables/extra_vars show right values and formatting in both yaml (---) and json ({})