From ce64a6bb6f5b032391c0d7f5e236daeb9866895c Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Fri, 15 Jan 2021 14:40:37 +0100 Subject: [PATCH] review feedback --- changelogs/fragments/346-ec2_vpc_endpoint_service_info.yml | 6 ++++++ plugins/modules/ec2_vpc_endpoint_info.py | 5 ++++- plugins/modules/ec2_vpc_endpoint_service_info.py | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/346-ec2_vpc_endpoint_service_info.yml diff --git a/changelogs/fragments/346-ec2_vpc_endpoint_service_info.yml b/changelogs/fragments/346-ec2_vpc_endpoint_service_info.yml new file mode 100644 index 00000000000..defedc5497e --- /dev/null +++ b/changelogs/fragments/346-ec2_vpc_endpoint_service_info.yml @@ -0,0 +1,6 @@ +minor_changes: +- ec2_vpc_endpoint_service_info - new module added for fetching information about available VPC endpoint services (https://github.com/ansible-collections/community.aws/pull/346). +deprecated_features: +- ec2_vpc_endpoint_info - the ``query`` option has been deprecated and will be removed after 2022-12-01 (https://github.com/ansible-collections/community.aws/pull/346). + The ec2_vpc_endpoint_info now defaults to listing information about endpoints. + The ability to search for information about available services has been moved to the dedicated module ``ec2_vpc_endpoint_service_info``. diff --git a/plugins/modules/ec2_vpc_endpoint_info.py b/plugins/modules/ec2_vpc_endpoint_info.py index 4f4bcc548f6..d919dd86af5 100644 --- a/plugins/modules/ec2_vpc_endpoint_info.py +++ b/plugins/modules/ec2_vpc_endpoint_info.py @@ -183,7 +183,10 @@ def main(): query = module.params.get('query') if query == 'endpoints': module.deprecate('The query option has been deprecated and' - ' will be removed after 2022-12-01', + ' will be removed after 2022-12-01. Searching for' + ' `endpoints` is now the default and after' + ' 2022-12-01 this module will only support fetching' + ' endpoints.', date='2022-12-01', collection_name='community.aws') elif query == 'services': module.deprecate('Support for fetching service information with this ' diff --git a/plugins/modules/ec2_vpc_endpoint_service_info.py b/plugins/modules/ec2_vpc_endpoint_service_info.py index 5ee59ed6d18..4038e94a24d 100644 --- a/plugins/modules/ec2_vpc_endpoint_service_info.py +++ b/plugins/modules/ec2_vpc_endpoint_service_info.py @@ -34,7 +34,7 @@ ''' EXAMPLES = r''' -# Simple example of listing all support AWS services for VPC endpoints +# Simple example of listing all supported AWS services for VPC endpoints - name: List supported AWS endpoint services community.aws.ec2_vpc_endpoint_service_info: region: ap-southeast-2