feat(parser): allow users install custom AST transforms #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| constructor(private _exprParser: Parser, private _schemaRegistry: ElementSchemaRegistry, | ||
| private _htmlParser: HtmlParser) {} | ||
| private _htmlParser: HtmlParser, injector: Injector) { | ||
| let transforms = isPresent(injector) ? injector.getOptional(TEMPLATE_TRANSFORMS) : null; |
There was a problem hiding this comment.
@vsavkin is this not the same as the following?
@Optional @Inject(TEMPLATE_TRANSFORMS) public transforms
yjbanov
changed the title
yjbanov
changed the title
| @@ -13,7 +13,8 @@ import { | |||
| assertionsEnabled, | |||
| isBlank | |||
| } from 'angular2/src/facade/lang'; | |||
| import {Injectable} from 'angular2/src/core/di'; | |||
| import {Injectable, Injector, OpaqueToken} from 'angular2/src/core/di'; | |||
There was a problem hiding this comment.
import form angular2/core.
yjbanov
force-pushed
the
template-transforms
branch
3 times, most recently
from
11f95d4
to
a1345e3
Compare
yjbanov
force-pushed
the
template-transforms
branch
from
a1345e3
to
6abaf32
Compare
|
Merging PR #5382 on behalf of @alxhub to branch presubmit-alxhub-pr-5382. |
| @@ -13,7 +13,8 @@ import { | |||
| assertionsEnabled, | |||
| isBlank | |||
| } from 'angular2/src/facade/lang'; | |||
| import {Injectable} from 'angular2/src/core/di'; | |||
| import {Injectable, Inject, Injector, OpaqueToken, Optional} from 'angular2/core'; | |||
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.