From 46bb08a9d0780fafef6dc5c1140c71912462887a Mon Sep 17 00:00:00 2001 From: Misko Hevery Date: Tue, 17 Apr 2012 13:58:25 -0700 Subject: [PATCH] fix(compiler): reading comment throws error in ie Unders some circumstances reading the comment's text throws error. --- src/ng/compiler.js | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/ng/compiler.js b/src/ng/compiler.js index 2ae2f891b942..59a701452899 100644 --- a/src/ng/compiler.js +++ b/src/ng/compiler.js @@ -467,12 +467,17 @@ function $CompileProvider($provide) { addTextInterpolateDirective(directives, node.nodeValue); break; case 8: /* Comment */ - match = COMMENT_DIRECTIVE_REGEXP.exec(node.nodeValue); - if (match) { - nName = directiveNormalize(match[1]); - if (addDirective(directives, nName, 'M', maxPriority)) { - attrs[nName] = trim(match[2]); + try { + match = COMMENT_DIRECTIVE_REGEXP.exec(node.nodeValue); + if (match) { + nName = directiveNormalize(match[1]); + if (addDirective(directives, nName, 'M', maxPriority)) { + attrs[nName] = trim(match[2]); + } } + } catch (e) { + // turns out that under some circumstances IE9 throws errors when one attempts to read comment's node value. + // Just ignore it and continue. (Can't seem to reproduce in test case.) } break; }