Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(ssrServer): added readiness check route #248

Merged
merged 5 commits into from
Jul 28, 2020

Conversation

10xLaCroixDrinker
Copy link
Member

Description

Added a new route for detecting the app is ready to take traffic

Motivation and Context

Allows deployment processes to detect the app is ready

How Has This Been Tested?

sent the route traffic locally and unit tests

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Smoother automated deployments

@10xLaCroixDrinker 10xLaCroixDrinker requested review from a team as code owners July 17, 2020 20:44
@oneamexbot
Copy link
Contributor

oneamexbot commented Jul 17, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 275.4KB 82.2KB
runtime.js 15KB 5.4KB
vendors.js 117.2KB 36.4KB
app~vendors.js 432.5KB 112.2KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 290.7KB 85.4KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 163.4KB 44.7KB
legacy/app~vendors.js 441.3KB 114.5KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against d67dbed

infoxicator
infoxicator previously approved these changes Jul 20, 2020
nellyk
nellyk previously approved these changes Jul 20, 2020
@@ -61,6 +61,7 @@ export function createApp({ enablePostToModuleRoutes = false } = {}) {
app.use(forwardedHeaderParser);

app.use('/_/static', express.static(path.join(__dirname, '../../build'), { maxage: '182d' }));
app.get('/_/ready', (req, res) => res.sendStatus(200));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought we were going to use /_/status

Copy link
Member Author

@10xLaCroixDrinker 10xLaCroixDrinker Jul 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it always returns a 200, status seems a bit too specific this was agreed on for restfulness

@JAdshead JAdshead merged commit a342e71 into master Jul 28, 2020
@JAdshead JAdshead deleted the feature/readiness-check branch July 28, 2020 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants