PP-11244 Remove handling for old GET token response #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencdaly
force-pushed
the
PP-11244-remove-handling-for-old-tokens-response
branch
from
cf98312
to
4d392b1
Compare
kbottla
reviewed
Jul 4, 2023
app/controllers/secure.controller.js
Outdated
| gatewayAccountId = tokenResponse.charge.gateway_account.gateway_account_id | ||
| gatewayAccountType = tokenResponse.charge.gateway_account.type | ||
| } | ||
| console.log('TOKEN RESPONSE: ' + JSON.stringify(tokenResponse)) |
There was a problem hiding this comment.
Thanks, removed
Connector has now been updated so that the GET token response uses the FrontendChargeResponse schema for the embedded charge rather than ChargeEntity. Remove the handling for the old response. Update `secure.controller.test.js` for this change, and refactor it slightly to make it easier to understand. Update the Pact test for the GET token endpoint to validate the embedded charge in the response using the new schema.
stephencdaly
force-pushed
the
PP-11244-remove-handling-for-old-tokens-response
branch
from
4d392b1
to
6ecb054
Compare
kbottla
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connector has now been updated so that the GET token response uses the FrontendChargeResponse schema for the embedded charge rather than ChargeEntity.
Remove the handling for the old response.
Update
secure.controller.test.jsfor this change, and refactor it slightly to make it easier to understand.Update the Pact test for the GET token endpoint to validate the embedded charge in the response using the new schema.