PP-10904 Make Worldpay Cypress tests standalone #3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iqbalgds
commented
Jun 21, 2023
iqbalgds
commented
- Cypress best practices suggest that having tests rely on the state of previous tests is an anti-pattern.
- Combine tests and remove use of Cypress.Cookies.preserveOnce() so that tests can be run independently.
iqbalgds
changed the title
kbottla
reviewed
Jun 21, 2023
test/cypress/integration/worldpay-3ds-flex-ddc/payment-with-session-id.cy.test.js
Show resolved
Hide resolved
iqbalgds
force-pushed
the
pp-10904-make-3ds-flex-cy-tests-standalone
branch
3 times, most recently
from
3d06506
to
2cecdce
Compare
iqbalgds
commented
Jul 11, 2023
test/cypress/integration/worldpay-3ds-flex-ddc/payment-with-session-id.cy.test.js
Outdated
Show resolved
Hide resolved
iqbalgds
force-pushed
the
pp-10904-make-3ds-flex-cy-tests-standalone
branch
from
2cecdce
to
20eafc9
Compare
iqbalgds
commented
Jul 11, 2023
test/cypress/integration/worldpay-3ds-flex-ddc/payment-with-session-id.cy.test.js
Outdated
Show resolved
Hide resolved
kbottla
reviewed
Jul 11, 2023
test/cypress/integration/worldpay-3ds-flex-ddc/payment-with-session-id.cy.test.js
Outdated
Show resolved
Hide resolved
| cy.server() | ||
| cy.route('POST', `/check_card/${chargeId}`).as('checkCard') | ||
|
|
||
| cy.log('Should enter payment details') |
There was a problem hiding this comment.
Can the code to enter payment details be extracted into a separate method for reuse?
There was a problem hiding this comment.
Good idea - will do that.
There was a problem hiding this comment.
Yes - this is done, thanks.
test/cypress/integration/worldpay-3ds-flex-ddc/payment-with-session-id.cy.test.js
Outdated
Show resolved
Hide resolved
- Cypress best practices suggest that having tests rely on the state of previous tests is an anti-pattern. - Combine tests and remove use of Cypress.Cookies.preserveOnce() so that tests can be run independently.
iqbalgds
force-pushed
the
pp-10904-make-3ds-flex-cy-tests-standalone
branch
from
20eafc9
to
fec2551
Compare
kbottla
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.