From 52490ea72b3bfdaa955771930b98048d48f69f10 Mon Sep 17 00:00:00 2001 From: Haroen Viaene Date: Thu, 27 Jun 2019 14:39:50 +0200 Subject: [PATCH] chore(lodash): remove dependencies - lodash from packages - babel-plugin-lodash from root - swap out isEqual from connectInfiniteHits IFW-778 closes #2468 --- babel.config.js | 1 - package.json | 1 - .../react-instantsearch-core/package.json | 1 - .../src/connectors/connectInfiniteHits.js | 2 +- .../react-instantsearch-dom-maps/package.json | 1 - packages/react-instantsearch-dom/package.json | 1 - yarn.lock | 33 ------------------- 7 files changed, 1 insertion(+), 39 deletions(-) diff --git a/babel.config.js b/babel.config.js index d4504c9343..c522736111 100644 --- a/babel.config.js +++ b/babel.config.js @@ -28,7 +28,6 @@ module.exports = api => { ], plugins: clean([ '@babel/plugin-proposal-class-properties', - 'babel-plugin-lodash', isRollup && 'babel-plugin-transform-react-remove-prop-types', ]), overrides: [ diff --git a/package.json b/package.json index b04eca905c..ba84943997 100644 --- a/package.json +++ b/package.json @@ -64,7 +64,6 @@ "babel-jest": "24.8.0", "babel-loader": "8.0.6", "babel-plugin-dynamic-import-node": "2.3.0", - "babel-plugin-lodash": "3.3.4", "babel-plugin-transform-react-remove-prop-types": "0.4.24", "bundlesize": "0.17.2", "conventional-changelog-cli": "2.0.21", diff --git a/packages/react-instantsearch-core/package.json b/packages/react-instantsearch-core/package.json index b2bf371667..5c23a5a37c 100644 --- a/packages/react-instantsearch-core/package.json +++ b/packages/react-instantsearch-core/package.json @@ -41,7 +41,6 @@ "@babel/runtime": "^7.1.2", "algoliasearch-helper": "^2.26.0", "fast-deep-equal": "^2.0.1", - "lodash": "^4.17.4", "prop-types": "^15.5.10" }, "peerDependencies": { diff --git a/packages/react-instantsearch-core/src/connectors/connectInfiniteHits.js b/packages/react-instantsearch-core/src/connectors/connectInfiniteHits.js index ad640fd1b9..fc4e0e06bd 100644 --- a/packages/react-instantsearch-core/src/connectors/connectInfiniteHits.js +++ b/packages/react-instantsearch-core/src/connectors/connectInfiniteHits.js @@ -1,4 +1,4 @@ -import { isEqual } from 'lodash'; +import isEqual from 'fast-deep-equal'; import createConnector from '../core/createConnector'; import { diff --git a/packages/react-instantsearch-dom-maps/package.json b/packages/react-instantsearch-dom-maps/package.json index 10808ea94b..7245243b10 100644 --- a/packages/react-instantsearch-dom-maps/package.json +++ b/packages/react-instantsearch-dom-maps/package.json @@ -42,7 +42,6 @@ }, "dependencies": { "@babel/runtime": "^7.1.2", - "lodash": "^4.17.4", "prop-types": "^15.5.10", "react-lifecycles-compat": "^3.0.4", "scriptjs": "^2.5.8" diff --git a/packages/react-instantsearch-dom/package.json b/packages/react-instantsearch-dom/package.json index 2a9c2b028a..bfca5b622e 100644 --- a/packages/react-instantsearch-dom/package.json +++ b/packages/react-instantsearch-dom/package.json @@ -43,7 +43,6 @@ "@babel/runtime": "^7.1.2", "algoliasearch-helper": "^2.26.0", "classnames": "^2.2.5", - "lodash": "^4.17.4", "prop-types": "^15.5.10", "react-instantsearch-core": "^5.7.0" }, diff --git a/yarn.lock b/yarn.lock index 465e728c6b..cd6b358e8b 100644 --- a/yarn.lock +++ b/yarn.lock @@ -290,14 +290,6 @@ dependencies: "@babel/types" "^7.0.0" -"@babel/helper-module-imports@^7.0.0-beta.49": - version "7.0.0-beta.51" - resolved "https://registry.yarnpkg.com/@babel/helper-module-imports/-/helper-module-imports-7.0.0-beta.51.tgz#ce00428045fbb7d5ebc0ea7bf835789f15366ab2" - integrity sha1-zgBCgEX7t9XrwOp7+DV4nxU2arI= - dependencies: - "@babel/types" "7.0.0-beta.51" - lodash "^4.17.5" - "@babel/helper-module-transforms@^7.1.0": version "7.2.2" resolved "https://registry.yarnpkg.com/@babel/helper-module-transforms/-/helper-module-transforms-7.2.2.tgz#ab2f8e8d231409f8370c883d20c335190284b963" @@ -1852,15 +1844,6 @@ globals "^11.1.0" lodash "^4.17.11" -"@babel/types@7.0.0-beta.51", "@babel/types@^7.0.0-beta.49": - version "7.0.0-beta.51" - resolved "https://registry.yarnpkg.com/@babel/types/-/types-7.0.0-beta.51.tgz#d802b7b543b5836c778aa691797abf00f3d97ea9" - integrity sha1-2AK3tUO1g2x3iqaReXq/APPZfqk= - dependencies: - esutils "^2.0.2" - lodash "^4.17.5" - to-fast-properties "^2.0.0" - "@babel/types@^7.0.0": version "7.0.0" resolved "https://registry.yarnpkg.com/@babel/types/-/types-7.0.0.tgz#6e191793d3c854d19c6749989e3bc55f0e962118" @@ -4817,17 +4800,6 @@ babel-plugin-jest-hoist@^24.6.0: dependencies: "@types/babel__traverse" "^7.0.6" -babel-plugin-lodash@3.3.4: - version "3.3.4" - resolved "https://registry.yarnpkg.com/babel-plugin-lodash/-/babel-plugin-lodash-3.3.4.tgz#4f6844358a1340baed182adbeffa8df9967bc196" - integrity sha512-yDZLjK7TCkWl1gpBeBGmuaDIFhZKmkoL+Cu2MUUjv5VxUZx/z7tBGBCBcQs5RI1Bkz5LLmNdjx7paOyQtMovyg== - dependencies: - "@babel/helper-module-imports" "^7.0.0-beta.49" - "@babel/types" "^7.0.0-beta.49" - glob "^7.1.1" - lodash "^4.17.10" - require-package-name "^2.0.1" - babel-plugin-macros@2.5.0, babel-plugin-macros@^2.0.0, babel-plugin-macros@^2.4.5: version "2.5.0" resolved "https://registry.yarnpkg.com/babel-plugin-macros/-/babel-plugin-macros-2.5.0.tgz#01f4d3b50ed567a67b80a30b9da066e94f4097b6" @@ -15396,11 +15368,6 @@ require-main-filename@^2.0.0: resolved "https://registry.yarnpkg.com/require-main-filename/-/require-main-filename-2.0.0.tgz#d0b329ecc7cc0f61649f62215be69af54aa8989b" integrity sha512-NKN5kMDylKuldxYLSUfrbo5Tuzh4hd+2E8NPPX02mZtn1VuREQToYe/ZdlJy+J3uCpfaiGF05e7B8W0iXbQHmg== -require-package-name@^2.0.1: - version "2.0.1" - resolved "https://registry.yarnpkg.com/require-package-name/-/require-package-name-2.0.1.tgz#c11e97276b65b8e2923f75dabf5fb2ef0c3841b9" - integrity sha1-wR6XJ2tluOKSP3Xav1+y7ww4Qbk= - requires-port@^1.0.0: version "1.0.0" resolved "https://registry.yarnpkg.com/requires-port/-/requires-port-1.0.0.tgz#925d2601d39ac485e091cf0da5c6e694dc3dcaff"