fix(store): delay call to listener to prevent infinite loops (#143)

Can happen when observing the loading property that change too fast.
algolia · Jun 29, 2017 · 0945958 · 0945958
1 parent 4f70a09
commit 0945958
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/packages/react-instantsearch/src/core/createStore.js b/packages/react-instantsearch/src/core/createStore.js
@@ -2,7 +2,7 @@ export default function createStore(initialState) {
   let state = initialState;
   const listeners = [];
   function dispatch() {
-    listeners.forEach(listener => listener());
+    listeners.forEach(listener => setTimeout(listener, 0));
   }
   return {
     getState() {

diff --git a/packages/react-instantsearch/src/core/createStore.test.js b/packages/react-instantsearch/src/core/createStore.test.js
@@ -2,6 +2,7 @@
 /* eslint-disable no-console */
 
 import createStore from './createStore';
+jest.useFakeTimers();
 
 describe('createStore', () => {
   describe('getState', () => {
@@ -17,7 +18,10 @@ describe('createStore', () => {
       const initialState = {};
       const store = createStore(initialState);
       const newState = {};
+
       store.setState(newState);
+      jest.runAllTimers();
+
       expect(store.getState()).toBe(newState);
     });
   });
@@ -31,6 +35,7 @@ describe('createStore', () => {
       const newState = {};
       expect(listener.mock.calls.length).toBe(0);
       store.setState(newState);
+      jest.runAllTimers();
       expect(listener.mock.calls.length).toBe(1);
     });
 
@@ -42,10 +47,12 @@ describe('createStore', () => {
       const newState = {};
       expect(listener.mock.calls.length).toBe(0);
       store.setState(newState);
+      jest.runAllTimers();
       expect(listener.mock.calls.length).toBe(1);
       unsubscribe();
       const newerState = {};
       store.setState(newerState);
+      jest.runAllTimers();
       expect(listener.mock.calls.length).toBe(1);
     });
   });