Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using searchOnEnterKeyPress + search, the url is not updated after the first query #2117

Closed
bobylito opened this issue Apr 20, 2017 · 1 comment

Comments

@bobylito
Copy link
Contributor

This a bug affects instantsearch.js 1.x

When using searchOnEnterKeyPress with a custom searchFunction that prevent some cases of search (empty query, query with under n letters), the url is not updated after the first results. The problem is identified here. The url sync bind the URL mechanics only after the first results have come back from Algolia.

This is a problem when the user blocks the initial first search using a searchFunction (which makes sense as they want to delay the first search until a user actually uses the search). This creates a limbo state for instantsearch making the url sync fail.

This is a tough one, because instantsearch.js has been created with the assumption that we're doing an initial search.

@bobylito
Copy link
Contributor Author

We won't fix this one, as it is an edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant