-
Notifications
You must be signed in to change notification settings - Fork 516
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(stats): Move CSS classes definition to widget from component
We can now easily spot in default.css which widget are not yet BEMified (yeah, that's a verb now). - Moved the BEM definition to widget instead of component - Updated the tests - This widget is using the headerFooter decorator, I updated the docs - The initial root class was added twice because we already used it in the default template. I removed the wrapping div in the template. BREAKING CHANGE: `cssClasses.root` now applies to the main root element (above header and footer) and no longer to the template wrapper. To style the template wrapper, use `cssClasses.body`
- Loading branch information
1 parent
3f72635
commit 99073cd
Showing
7 changed files
with
72 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,8 @@ | ||
module.exports = { | ||
header: '', | ||
body: `<div class="{{cssClasses.root}}"> | ||
{{#hasNoResults}}No results{{/hasNoResults}} | ||
body: `{{#hasNoResults}}No results{{/hasNoResults}} | ||
{{#hasOneResult}}1 result{{/hasOneResult}} | ||
{{#hasManyResults}}{{#helpers.formatNumber}}{{nbHits}}{{/helpers.formatNumber}} results{{/hasManyResults}} | ||
<span class="{{cssClasses.time}}">found in {{processingTimeMS}}ms</span> | ||
</div>`, | ||
<span class="{{cssClasses.time}}">found in {{processingTimeMS}}ms</span>`, | ||
footer: '' | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters