From d36a2ad29e3be5a3dd84f715c2995dde058c30e5 Mon Sep 17 00:00:00 2001 From: Pixelastic Date: Tue, 22 Sep 2015 10:21:26 +0200 Subject: [PATCH] fix: More explicit error message when DOM selector is invalid Fixed #105 --- lib/utils.js | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/lib/utils.js b/lib/utils.js index c4e4f11ce2..77adbd261f 100644 --- a/lib/utils.js +++ b/lib/utils.js @@ -1,13 +1,21 @@ function getContainerNode(selectorOrHTMLElement) { - if (typeof selectorOrHTMLElement === 'string') { - return document.querySelector(selectorOrHTMLElement); + var isFromString = (typeof selectorOrHTMLElement === 'string'); + var domElement; + if (isFromString) { + domElement = document.querySelector(selectorOrHTMLElement); + } else { + domElement = selectorOrHTMLElement; } - if (!isDomElement(selectorOrHTMLElement)) { - throw new Error('Container must be `string` or `HTMLElement`'); + if (!isDomElement(domElement)) { + var errorMessage = 'Container must be `string` or `HTMLElement`.'; + if (isFromString) { + errorMessage += ' Unable to find ' + selectorOrHTMLElement; + } + throw new Error(errorMessage); } - return selectorOrHTMLElement; + return domElement; } function isDomElement(o) {