feat(connectCurrentRefinements): add a root label (PART 1) #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will always be identical to the attribute, and will be the thing which will be displayed. The reason why you'd want a key like this is if you e.g. want to rename a single key or transform all keys to be upper case, without actually changing which attribute will be changed.
|
Deploy preview for instantsearchjs ready! Built with commit 232e486 |
tkrugg
approved these changes
Feb 11, 2019
francoischalifour
approved these changes
Feb 11, 2019
…3518) Thinking about it, I think this might be a major change unfortunately
|
We need to update the documentation. |
Haroenv
added a commit
to algolia/vue-instantsearch
that referenced
this pull request
Feb 12, 2019
Haroenv
added a commit
to algolia/vue-instantsearch
that referenced
this pull request
Feb 13, 2019
* feat(core): update to InstantSearch.js v3 These are so far only the component changes, not the changes in their tests. All of this behaviour needs to be double checked and breaking changes noted (notably ais-current-refinements is very different now) * chore: consistent comment wording * feat(CurrentRefinements): split up "item" and "refinement" slots (#619) * feat(CurrentRefinements): add a "refinement" slot * chore: flip naming * chore(current): revert to existing API * test(CurrentRefinements): update with new DOM * test(HierarchicalMenu): showMore v3 update * test(v3): update all tests * ci(lint): add ignore lines * ci(lint): add note :( * feat(CurrentRefinements): use label see algolia/instantsearch#3515 * ci(lint): ignore error that's wrong * chore: remove stray comment Co-Authored-By: Haroenv <fingebimus@me.com> * chore(stories): currentRefinement label * fix(hierarchicalMenu): make showMore use connector logic * chore(breadcrumb): modify slot * chore: remove needless comment
Haroenv
added a commit
that referenced
this pull request
Dec 28, 2022
) * feat(core): update to InstantSearch.js v3 These are so far only the component changes, not the changes in their tests. All of this behaviour needs to be double checked and breaking changes noted (notably ais-current-refinements is very different now) * chore: consistent comment wording * feat(CurrentRefinements): split up "item" and "refinement" slots (algolia/vue-instantsearch#619) * feat(CurrentRefinements): add a "refinement" slot * chore: flip naming * chore(current): revert to existing API * test(CurrentRefinements): update with new DOM * test(HierarchicalMenu): showMore v3 update * test(v3): update all tests * ci(lint): add ignore lines * ci(lint): add note :( * feat(CurrentRefinements): use label see #3515 * ci(lint): ignore error that's wrong * chore: remove stray comment Co-Authored-By: Haroenv <fingebimus@me.com> * chore(stories): currentRefinement label * fix(hierarchicalMenu): make showMore use connector logic * chore(breadcrumb): modify slot * chore: remove needless comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The reason why you'd want a key like this is if you e.g. want to rename a single key or transform all keys to be upper case, without actually changing which attribute will be changed.
Result
A new root key
label, this will always be identical to the attribute, and will be the thing which will be displayed.