-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): fix cssClasses of voiceSearch #3783
Conversation
fixing the lint errors now.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linting is failing though 🤔
Deploy preview for instantsearchjs ready! Built with commit c8fb656 |
Here's a headache. The reason why the lint failed is because the type of At the widget, export type VoiceSearchCSSClasses = {
root: string | string[];
button: string | string[];
status: string | string[];
}; At the component, export type VoiceSearchComponentCSSClasses = {
root: string;
button: string;
status: string;
}; Here, So as a workaround, I casted Do you have any better idea? |
## [3.5.3](v3.5.2...v3.5.3) (2019-05-28) ### Bug Fixes * **voiceSearch:** let the connector handle the default value of searchAsYouSpeak when it's not given ([#3817](#3817)) ([9d3e91b](9d3e91b)) * **getTag:** use object version of toString ([#3820](#3820)) ([a7348ea](a7348ea)) * **types:** fix cssClasses of voiceSearch ([#3783](#3783)) ([f016326](f016326))
Summary
This allows the widget can accept an array of string as css classes.
This was missing in the first place, allowing only strings.