Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windowTitle does not trigger when page loads #3667

Closed
sparanoid opened this issue Apr 7, 2019 · 1 comment · Fixed by #3669
Closed

windowTitle does not trigger when page loads #3667

sparanoid opened this issue Apr 7, 2019 · 1 comment · Fixed by #3669

Comments

@sparanoid
Copy link

sparanoid commented Apr 7, 2019 •
edited
Loading

Describe the bug 🐛
The windowTitle option for routing does not trigger when the page first loads.

To Reproduce 🔍
This issue can be easily reproduced via official SEO friendly URLs demo

  1. Open demo via CodeSandbox
  2. Run the demo and click "Open in New Window"
  3. Type something to search, notice the title change
  4. Refresh the page using browser reload.
  5. Title does not change.

Expected behavior 💭
The page title should contains correct queries from windowTitle after page reload.

Screencast 🎬
https://www.useloom.com/share/96c3c8f3329041c7bc6d74e232812ad4

Environment:

  • OS: macOS
  • Browser: Google Chrome
  • Version: 73.0.3683.86

Additional context
Add any other context about the problem here.
@francoischalifour francoischalifour mentioned this issue Apr 8, 2019
Merged
@francoischalifour
Copy link
Member

francoischalifour commented Apr 8, 2019 •
edited
Loading

Thank you for reporting the issue. This is addressed in #3669.

francoischalifour added a commit that referenced this issue Apr 8, 2019
@francoischalifour
fix(routing): apply windowTitle on first load (#3669)
d553502 
Closes #3667.
francoischalifour added a commit that referenced this issue Apr 11, 2019
@francoischalifour
v3.3.0
172783c 
# [3.3.0](v3.2.1...v3.3.0) (2019-04-11)

### Bug Fixes

* **connectQueryRules:** improve tracked refinement type ([#3648](#3648)) ([e16ad57](e16ad57))
* **currentRefinements:** don't rely on  ([#3672](#3672)) ([cd64bcf](cd64bcf))
* **queryRuleCustomData:** add default template ([#3650](#3650)) ([83e9eaa](83e9eaa))
* **QueryRuleCustomData:** pass data as object to templates ([#3647](#3647)) ([b8f8b4e](b8f8b4e))
* **queryRules:** fix types and stories ([#3670](#3670)) ([ba6e2e6](ba6e2e6))
* **routing:** apply windowTitle on first load ([#3669](#3669)) ([d553502](d553502)), closes [#3667](#3667)
* **routing:** support parsing URLs with up to 100 refinements ([#3671](#3671)) ([6ddcfb6](6ddcfb6))
* **RoutingManager:** avoid stale uiState ([#3630](#3630)) ([e1588aa](e1588aa))
* **types:** improve InstantSearch types ([#3651](#3651)) ([db9b91e](db9b91e))
* **ua:** Update the User-Agent to use the new format ([#3616](#3616)) ([ab84c57](ab84c57))

### Features

* **infiniteHits:** add previous button ([#3645](#3645)) ([2c9e38d](2c9e38d))
* **queryRules:** add connectQueryRules connector ([#3597](#3597)) ([924cd99](924cd99)), closes [#3599](#3599) [#3600](#3600)
* **queryRules:** add context features to Query Rules ([#3617](#3617)) ([922879e](922879e)), closes [#3602](#3602)

### Reverts

* feat(infiniteHits): add previous button ([214c0fc](214c0fc))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(routing): apply windowTitle on first load algolia/instantsearch
2 participants
@sparanoid @francoischalifour