Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Stats): let the widget render on all values #3070

Merged
merged 2 commits into from
Aug 20, 2018
Merged

fix(Stats): let the widget render on all values #3070

merged 2 commits into from
Aug 20, 2018

Conversation

bobylito
Copy link
Contributor

This removes the implementation of shouldComponentUpdate. This can be seen as a regression but given that it's a pretty simple widget, the impact shouldn't be noticeable.

Fix #3056

This removes the implementation of shouldComponentUpdate. This can be
seen as a regression but given that it's a pretty simple widget, the
impact shouldn't be noticeable.

Fix #3056
@algobot
Copy link
Contributor

algobot commented Aug 20, 2018

Deploy preview for algolia-instantsearch ready!

Built with commit c7d8a3c

https://deploy-preview-3070--algolia-instantsearch.netlify.com

@samouss
Copy link
Contributor

samouss commented Aug 20, 2018

We implement this hook in several other components ClearAll, PaginationLink, RefinementListItem, ... We can also take a look at this other components. This hook is an escape hatch in most cases we don't need to implement it. Except when we hit a performance issue.

@bobylito
Copy link
Contributor Author

We implement this hook in several other components ClearAll, PaginationLink, RefinementListItem, ... We can also take a look at this other components. This hook is an escape hatch in most cases we don't need to implement it. Except when we hit a performance issue.

Unlike this component, the others don't create issue as far as we know and they have been implemented as part of a general performance. Let's consider the case of the other on case by case basis.

@bobylito bobylito merged commit cd8f17e into develop Aug 20, 2018
@bobylito bobylito deleted the fix/3056 branch August 20, 2018 15:10
bobylito pushed a commit that referenced this pull request Sep 10, 2018
<a name=2.10.2></a>
## [2.10.2](v2.10.1...v2.10.2) (2018-09-10)

### Bug Fixes

* **searchbox:** Add missing color to searchbox input field ([#3086](#3086)) ([62b852a](62b852a)), closes [#3075](#3075)
* **Stats:** let the widget render on all values ([#3070](#3070)) ([cd8f17e](cd8f17e)), closes [#3056](#3056)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants