Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yarnrc): use empty string for save-prefix #2739

Merged
merged 2 commits into from
Feb 15, 2018
Merged

fix(yarnrc): use empty string for save-prefix #2739

merged 2 commits into from
Feb 15, 2018

Conversation

samouss
Copy link
Contributor

@samouss samouss commented Feb 15, 2018

Summary

We introduced a .yarnrc file recently, but by setting the value to false introduce this kind issue:

"enzyme-adapter-react-15": "false1.0.5"

By setting the value to an empty string we get the expected result which is:

"enzyme-adapter-react-15": "1.0.5"

@algobot
Copy link
Contributor

algobot commented Feb 15, 2018

Deploy preview for algolia-instantsearch ready!

Built with commit 6516614

https://deploy-preview-2739--algolia-instantsearch.netlify.com

@bobylito
Copy link
Contributor

bobylito commented Feb 15, 2018

👍 Can you also fix the package.json? @samouss ;)

@samouss
Copy link
Contributor Author

samouss commented Feb 15, 2018

@bobylito Done!

@algobot
Copy link
Contributor

algobot commented Feb 15, 2018

Deploy preview for algolia-instantsearch ready!

Built with commit a553cb4

https://deploy-preview-2739--algolia-instantsearch.netlify.com

Copy link
Contributor

@bobylito bobylito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bobylito bobylito merged commit 979e0cd into develop Feb 15, 2018
@bobylito bobylito deleted the fix/yarnrc branch February 15, 2018 14:32
@algobot
Copy link
Contributor

algobot commented Feb 15, 2018

Deploy preview for algolia-instantsearch ready!

Built with commit 19c3131

https://deploy-preview-2739--algolia-instantsearch.netlify.com

bobylito pushed a commit that referenced this pull request Feb 26, 2018
<a name=2.5.2></a>
## [2.5.2](v2.5.1...v2.5.2) (2018-02-26)

### Bug Fixes

* **Template:** harden Symbol checks ([#2749](#2749)) ([fab66bc](fab66bc))
* **yarnrc:** use empty string for save-prefix ([#2739](#2739)) ([979e0cd](979e0cd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants