Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images don't have a max-width in the documentation container #2685

Closed
francoischalifour opened this issue Jan 31, 2018 · 2 comments
Closed

Images don't have a max-width in the documentation container #2685

francoischalifour opened this issue Jan 31, 2018 · 2 comments
Labels
Design: API

Comments

@francoischalifour
Copy link
Member

Do you want to request a feature or report a bug?

Bug

I'm writing a guide and wanted to add a screenshot. The image is 800px wide and overflows in most cases.

Bug: What is the current behavior?

Images in .documentation-container don't have any maximum size.

localhost_3002_v2_guides_calendar-widget html ipad pro 1

(rendered as an iPad Pro)

Bug: What is the expected behavior?

localhost_3002_v2_guides_calendar-widget html ipad pro

Bug: What browsers are impacted? Which versions?

All

Bug: What is the proposed solution?

We should probably set max-width: 100%; to images inside .documentation-container.

cc @LukyVj probably
@bobylito
Copy link
Contributor

Since @LukyVj is very busy, you could fix it on your end. And he will tell you if that's the incorrect way to fix :)

@francoischalifour
Copy link
Member Author

Got it!

francoischalifour added a commit that referenced this issue Jan 31, 2018
@francoischalifour
fix(doc): add maximum width to images (fix #2685)
51adc14
@francoischalifour francoischalifour mentioned this issue Jan 31, 2018
Merged
bobylito pushed a commit that referenced this issue Feb 6, 2018
v2.5.0
1d66f35 
<a name=2.5.0></a>
# [2.5.0](v2.4.1...v2.5.0) (2018-02-06)

### Bug Fixes

* **doc:** add maximum width to images (fix [#2685](#2685)) ([#2686](#2686)) ([f4b5377](f4b5377))

### Features

* support for algolia insights ([#2689](#2689)) ([96b8d61](96b8d61))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Design: API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobylito @francoischalifour