Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add an error event to monitor error from Algolia #2642

Merged
merged 1 commit into from
Dec 29, 2017
Merged

feat(core): add an error event to monitor error from Algolia #2642

merged 1 commit into from
Dec 29, 2017

Conversation

bobylito
Copy link
Contributor

Fix #1585

Adds an event that is emitted when an error is received in place of results.

@algobot
Copy link
Contributor

algobot commented Dec 28, 2017

Deploy preview ready!

Built with commit 19ce562

https://deploy-preview-2642--algolia-instantsearch.netlify.com

Haroenv
Haroenv approved these changes Dec 29, 2017
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I didn’t know we had events

@bobylito
Copy link
Contributor Author

bobylito commented Dec 29, 2017 •
edited
Loading

We had one up until now, render which is used to give an information about the end of the rendering step. They are used to provide information that we can't provide using widgets.

@Haroenv
Copy link
Contributor

Haroenv commented Dec 29, 2017

the more you know

@bobylito bobylito merged commit 71c2d68 into develop Dec 29, 2017
marielaures pushed a commit that referenced this pull request Dec 29, 2017
@bobylito @marielaures
feat(core): add an error event to monitor error from Algolia (#2642)
5bac7a3 
Fix #1585
marielaures pushed a commit that referenced this pull request Dec 29, 2017
@bobylito @marielaures
feat(core): add an error event to monitor error from Algolia (#2642)
aafa270 
Fix #1585
bobylito pushed a commit that referenced this pull request Jan 2, 2018
v2.4.0
62410ea 
<a name=2.4.0></a>

* **pagination:** disable buttons if not results ([#2643](#2643)) ([9017b72](9017b72)), closes [#2014](#2014)
* **theme:** fix height of pagination ([#2641](#2641)) ([b3185e5](b3185e5))

* **core:** add a reload method on the InstantSearch component ([#2637](#2637)) ([e73ff13](e73ff13))
* **core:** add an error event to monitor error from Algolia ([#2642](#2642)) ([71c2d68](71c2d68)), closes [#1585](#1585)
* **core:** rename `reload` to `refresh` ([#2645](#2645)) ([9b8ac65](9b8ac65))
* **wrapWithHits:** enable async init ([#2635](#2635)) ([08a8747](08a8747))
@francoischalifour francoischalifour deleted the feat/error-event branch October 4, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobylito @algobot @Haroenv