fix(sffv): no error when not providing noResults and no results #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there was no results and the template is not provided, is.js would trigger an error. Fix #2087
|
Deploy preview ready! Built with commit ba56d0b https://deploy-preview-2310--algolia-instantsearch.netlify.com |
Haroenv
approved these changes
Sep 5, 2017
| @@ -253,7 +254,7 @@ export default function refinementList( | |||
| ? prefixKeys('show-more-', showMoreConfig.templates) | |||
| : {}; | |||
| const searchForValuesTemplates = searchForFacetValues | |||
| ? searchForFacetValues.templates | |||
| ? searchForFacetValues.templates || sffvDefaultTemplates | |||
| : {}; | |||
There was a problem hiding this comment.
This condition seems a bit complex to me. I'm wondering if something like this is more straightforward:
const searchForValuesTemplates = searchForFacetValues
? searchForFacetValues.templates
? searchForFacetValues.templates
: sffvDefaultTemplates
: {};It's still a double ternary, but this might be easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there was no results and the template is not provided, is.js would trigger an error.
Fix #2087