Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url sync examples implementation should not update at every character #1856

Closed
vvo opened this issue Jan 18, 2017 · 0 comments
Closed

Url sync examples implementation should not update at every character #1856

vvo opened this issue Jan 18, 2017 · 0 comments
Assignees
@vvo
Labels
Doc: Examples Doc: Website

Comments

@vvo
Copy link
Contributor

vvo commented Jan 18, 2017

No description provided.

@vvo vvo self-assigned this Jan 26, 2017
vvo pushed a commit that referenced this issue Jan 26, 2017
docs(examples): urlSync example implem now update URL every 700ms
a3d7d8e 
Before this commit, we were advocating for updating the url at every keystrokes.
We had multiple reports since releases of instansearch.js that this led to slowdowns
of the browser UI.

fixes #1856
@vvo vvo mentioned this issue Jan 26, 2017
Merged
vvo pushed a commit that referenced this issue Jan 26, 2017
fix(urlSync): update url only after threshold
a9261ba 
Before this commit, our default implementation tried to update
the url at every character. This led to many slowdown reports from users
of the library.

Now we only update the url after the threshold

fixes #1856
vvo pushed a commit that referenced this issue Jan 27, 2017
docs(examples): urlSync example implem now update URL every 700ms
701adb7 
Before this commit, we were advocating for updating the url at every keystrokes.
We had multiple reports since releases of instansearch.js that this led to slowdowns
of the browser UI.

fixes #1856
vvo pushed a commit that referenced this issue Jan 27, 2017
docs(examples): urlSync example implem now update URL every 700ms
88b1286 
Before this commit, we were advocating for updating the url at every keystrokes.
We had multiple reports since releases of instansearch.js that this led to slowdowns
of the browser UI.

fixes #1856
@vvo vvo closed this as completed in #1916 Jan 27, 2017
vvo added a commit that referenced this issue Jan 27, 2017
@vvo
docs(examples): urlSync example implem now update URL every 700ms (#1916
fd77c49 
)

Before this commit, we were advocating for updating the url at every keystrokes.
We had multiple reports since releases of instansearch.js that this led to slowdowns
of the browser UI.

fixes #1856
vvo added a commit that referenced this issue Jan 27, 2017
@vvo
fix(urlSync): update url only after threshold (#1917)
b0f0cf1 
Before this commit, our default implementation tried to update
the url at every character. This led to many slowdown reports from users
of the library.

Now we only update the url after the threshold

fixes #1856
vvo pushed a commit that referenced this issue Feb 6, 2017
v1.10.5
cb77dde 
<a name="1.10.5"></a>
## [1.10.5](v1.10.4...v1.10.5) (2017-02-06)

### Bug Fixes

* **urlSync:** update url only after threshold (#1917) ([b0f0cf1](b0f0cf1)), closes [#1856](#1856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vvo vvo

Labels
Doc: Examples Doc: Website
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vvo