-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 15.3.1 shouldn't be a dependency. #1386
Comments
Hi @salazareddie, thanks for the issue. Can you explain and comment how/if the current state is triggering some bad behavior on your side? Thanks |
Yep you're right thanks, it should be a peerDependency thought right? Because if you use this with npm, you will need react to be installed. Thus a peer will indicate this to you. Also this may break some existing installations of instantsearch.js for npm users if we do this. For sure next breaking version we will do it, but for now we cannot. What we can do is move to "^15.0.0" instead of "15.3.2" would that be fine for you? So that npm resolves this well. |
@vvo Yes, it should be a peerDependency. Moving to |
Ok so we are gonna move to ^15.0.0 put stick with dependencies field. We will move to peerDependency in another breaking version. None planned yet. |
@salazareddie What's the react version you are using right now? |
@vvo We are using 0.14.8. Tested the above solution locally and will do the trick. Just get these warnings when I npm install:
|
ok fine then thx, will do it assap |
@vvo any updates on this? |
Ultimately we should have React as a peerDependency. fixes #1386
Ultimately we should have React as a peerDependency. fixes #1386
Going to do a release in the coming hour, are you a react user? We do have a react specific set of components in the work right now if you want to beta test it, email at vincent@algolia.com thx |
Ultimately we should have React as a peerDependency. fixes #1386
Ultimately we should have React as a peerDependency. fixes #1386
should be fixed, let me know |
@vvo Do you want me to add a separate issue for moving the dependency to peer dependencies? |
@salazareddie It's ok we'll do it but only on a breaking change, should happen this year :) |
Propose using
"react": "^0.14.0"
in devdependenciesSee this example
The text was updated successfully, but these errors were encountered: