fix(searchBox): stop updating query at eachkeystroke with searchOnEnt…

…erKeyPressOnly

fixes #875

src/widgets/search-box/__tests__/search-box-test.js

@@ -247,7 +247,7 @@ describe('searchBox()', () => {
 
       it('does not performs (will be handle by keyup event)', () => {
         simulateInputEvent();
-        expect(helper.setQuery.calledOnce).toBe(true);
+        expect(helper.setQuery.calledOnce).toBe(false);
         expect(helper.search.called).toBe(false);
       });
     });
@@ -289,14 +289,20 @@ describe('searchBox()', () => {
         widget.getInput = sinon.stub().returns(input);
       });
 
+      it('sets the query on keyup if <ENTER>', () => {
+        simulateKeyUpEvent({keyCode: 13});
+        expect(helper.setQuery.calledOnce).toBe(true);
+      });
+
       it('performs the search on keyup if <ENTER>', () => {
         simulateKeyUpEvent({keyCode: 13});
         expect(helper.search.calledOnce).toBe(true);
       });
 
       it('doesn\'t perform the search on keyup if not <ENTER>', () => {
         simulateKeyUpEvent({});
-        expect(helper.search.calledOnce).toBe(false);
+        expect(helper.setQuery.called).toBe(false);
+        expect(helper.search.called).toBe(false);
       });
     });
   });

src/widgets/search-box/search-box.js

@@ -135,21 +135,21 @@ function searchBox({
       // Add all the needed attributes and listeners to the input
       this.addDefaultAttributesToInput(input, state.query);
 
-      // always set the query on every change
-      addListener(input, INPUT_EVENT, setQuery);
-
-      // handle IE8 weirdness where BACKSPACE key will not trigger an input change..
-      // can be removed as soon as we remove support for it
-      if (INPUT_EVENT === 'propertychange' || window.attachEvent) {
-        addListener(input, 'keyup', ifKey(KEY_SUPPRESS, setQuery));
-        addListener(input, 'keyup', ifKey(KEY_SUPPRESS, search));
-      }
-
-      // only search on enter
+      // only update query and search on enter
       if (searchOnEnterKeyPressOnly) {
+        addListener(input, 'keyup', ifKey(KEY_ENTER, setQuery));
         addListener(input, 'keyup', ifKey(KEY_ENTER, search));
       } else {
+        // always set the query and search on every keystrokes
+        addListener(input, INPUT_EVENT, setQuery);
         addListener(input, INPUT_EVENT, search);
+
+        // handle IE8 weirdness where BACKSPACE key will not trigger an input change..
+        // can be removed as soon as we remove support for it
+        if (INPUT_EVENT === 'propertychange' || window.attachEvent) {
+          addListener(input, 'keyup', ifKey(KEY_SUPPRESS, setQuery));
+          addListener(input, 'keyup', ifKey(KEY_SUPPRESS, search));
+        }
       }
 
       function setQuery(e) {