fix(selector): makes component as uncontrolled component

algolia · Nov 5, 2015 · 1dda12a · 1dda12a
1 parent 68adc0d
commit 1dda12a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/components/Selector.js b/components/Selector.js
@@ -13,8 +13,8 @@ class Selector extends React.Component {
     return (
       <select
         className={this.props.cssClasses.root}
+        defaultValue={currentValue}
         onChange={handleChange}
-        value={currentValue}
       >
         {options.map((option) => {
           return <option className={this.props.cssClasses.item} key={option.value} value={option.value}>{option.label}</option>;

diff --git a/components/__tests__/Selector-test.js b/components/__tests__/Selector-test.js
@@ -29,8 +29,8 @@ describe('Selector', () => {
     expect(out).toEqualJSX(
       <select
         className="custom-root"
+        defaultValue="index-a"
         onChange={() => {}}
-        value="index-a"
       >
         <option className="custom-item" value="index-a">Index A</option>
         <option className="custom-item" value="index-b">Index B</option>
@@ -50,8 +50,8 @@ describe('Selector', () => {
     expect(out).toEqualJSX(
       <select
         className="custom-root"
+        defaultValue={10}
         onChange={() => {}}
-        value={10}
       >
         <option className="custom-item" value={10}>10 results per page</option>
         <option className="custom-item" value={20}>20 results per page</option>