-
Notifications
You must be signed in to change notification settings - Fork 516
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(lifecycle): save configuration done in widget.init
Before this commit, every configuration done in widget.init would not be remembered when going back in the browser history. Scenario: You built a custom widget using helper.setQueryParameter in widget.init. Then you load "/", widget.init() sets some helper params, you go to page 2, you click on <= back. Before this commit we would forget what was done in widget.init(). Now it works. This was needed to fix the "rootPath" option of the hierarchicalMenu. The rootPath option triggers a state change from inside the helper (which may have been a bad idea after all) => it was not remembered when going back to empty url. Thanks to @maxiloc for the bug report and big help solving this!
- Loading branch information
vvo
committed
Apr 26, 2016
1 parent
624da3f
commit 07d1fea
Showing
4 changed files
with
38 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters