From 45d433d0acbdbdcd948323d104f880b162d9fd14 Mon Sep 17 00:00:00 2001
From: Pierre Millot <pierre.millot@algolia.com>
Date: Thu, 10 Oct 2024 12:29:11 +0200
Subject: [PATCH] fix(specs): correct type for banners [skip-bc] (#3939)

---
 .../com/algolia/codegen/AlgoliaSwiftGenerator.java    |  1 -
 specs/common/schemas/IndexSettings.yml                | 11 ++++++-----
 .../clients/algoliasearch/builds/models.mustache      |  2 --
 3 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/generators/src/main/java/com/algolia/codegen/AlgoliaSwiftGenerator.java b/generators/src/main/java/com/algolia/codegen/AlgoliaSwiftGenerator.java
index 97e7f94eee..7120bbef44 100644
--- a/generators/src/main/java/com/algolia/codegen/AlgoliaSwiftGenerator.java
+++ b/generators/src/main/java/com/algolia/codegen/AlgoliaSwiftGenerator.java
@@ -42,7 +42,6 @@ public class AlgoliaSwiftGenerator extends Swift5ClientCodegen {
     "bannerimage",
     "bannerimageurl",
     "bannerlink",
-    "banners",
     "baseindexsettings",
     "basesearchparams",
     "basesearchparamswithoutquery",
diff --git a/specs/common/schemas/IndexSettings.yml b/specs/common/schemas/IndexSettings.yml
index c1490318d4..995ed8c071 100644
--- a/specs/common/schemas/IndexSettings.yml
+++ b/specs/common/schemas/IndexSettings.yml
@@ -1036,9 +1036,8 @@ banners:
   description: banners defined in the merchandising studio for the given search.
   type: array
   additionalProperties: false
-  properties:
-    banners:
-      $ref: '#/banner'
+  items:
+    $ref: '#/banner'
 
 banner:
   description: a search banner with image and url.
@@ -1064,13 +1063,15 @@ bannerImage:
   additionalProperties: false
   properties:
     urls:
-      $ref: '#/bannerImageUrl'
+      type: array
+      items:
+        $ref: '#/bannerImageUrl'
     title:
       type: string
 
 bannerImageUrl:
   description: url for a search banner image.
-  type: array
+  type: object
   additionalProperties: false
   properties:
     url:
diff --git a/templates/javascript/clients/algoliasearch/builds/models.mustache b/templates/javascript/clients/algoliasearch/builds/models.mustache
index ac93e8ae15..1829c343de 100644
--- a/templates/javascript/clients/algoliasearch/builds/models.mustache
+++ b/templates/javascript/clients/algoliasearch/builds/models.mustache
@@ -16,7 +16,6 @@ import type {
   BannerImage,
   BannerImageUrl,
   BannerLink,
-  Banners,
   BaseIndexSettings,
   BaseSearchParams,
   BaseSearchParamsWithoutQuery,
@@ -112,7 +111,6 @@ export {
   BannerImage,
   BannerImageUrl,
   BannerLink,
-  Banners,
   BaseIndexSettings,
   BaseSearchParams,
   BaseSearchParamsWithoutQuery,