feat: Expose polling interval as a sensor #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
It seems the pre-commit is throwing Fatal Errors |
alandtse
approved these changes
Apr 24, 2024
bdraco
added a commit
to bdraco/tesla
that referenced
this pull request
Apr 26, 2024
alandtse#948 made me realize that the car data was being polled far less frequently than I thought as the underlying library was caching, but every time the coordinator fired, it would still callback all the listeners and write the state of all the entities which meant we ended up writing state every 10 seconds even if nothing has changed. Since the data the coordinator returns can be compared with __eq__, enabling always_update=False will check if the data has changed and only fire the listeners if it has. This avoids 1000s of entity writes per minute which was the bulk of the state writes on my HA instance
bdraco
added a commit
to bdraco/tesla
that referenced
this pull request
Apr 26, 2024
alandtse#948 made me realize that the car data was being polled far less frequently than I thought as the underlying library was caching, but every time the coordinator fired, it would still callback all the listeners and write the state of all the entities which meant we ended up writing state every 10 seconds even if nothing has changed. Keep track of when the controller was last updated in each entity and if it has not changed, we skip the state write. This reduced the number of calls to `async_write_ha_state` by 62% on my production HA instance!
alandtse
pushed a commit
that referenced
this pull request
Apr 26, 2024
* perf: avoid writing state when the controller did not actually update #948 made me realize that the car data was being polled far less frequently than I thought as the underlying library was caching, but every time the coordinator fired, it would still callback all the listeners and write the state of all the entities which meant we ended up writing state every 10 seconds even if nothing has changed. Keep track of when the controller was last updated in each entity and if it has not changed, we skip the state write. This reduced the number of calls to `async_write_ha_state` by 62% on my production HA instance! * fix async_added_to_hass was being overridden and forgot to remove in pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the polling interval as a sensor as requested in #946