fix: set data to default of None #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maruel
changed the title
|
I haven't tested this, did you actually run this to see if it helps? I believe it's harmless enough with the existing code though but would appreciate confirmation. |
|
I haven't, I just read the code and found the bug. To reproduce, one has to have expired credentials, to get in the except clause on line 467 and without reload_lock held. I believe this happens if you get there by clicking on the notification. Then line 485 blews up because data is undefined via this code path. This PR just makes sure data is always defined. |
alandtse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #907