fix: calculate assumed state only once #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
changed the title
|
Sounds like this may be a perf: since it could improve performance. |
bdraco
changed the title
alandtse
force-pushed
the
assumed_state
branch
from
f9c2bd3
to
f6c7536
Compare
assumed_state on the entities was calculated for each entity which meant we had to do it 1000s of times per minute when there were a lot of vins.
alandtse
force-pushed
the
assumed_state
branch
from
f6c7536
to
a85e7a9
Compare
alandtse
changed the title
|
Thanks Side note: 2023.1.x should reduce the cost of the frequent state writes from polling by ~50% plus another 14-17% from this change |
|
Thanks for the contrib. My biggest concern is we may lose all api access in a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assumed_state on the entities was calculated for each entity. We can calculate it once per update instead.