New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: memorize unique id #534

Merged

alandtse merged 2 commits into alandtse:dev from bdraco:memorize_slug

Mar 14, 2023

Contributor

bdraco commented Mar 13, 2023 •

edited

Loading

slugify is a relatively expensive operation because it has to do unicode work.

Ideally we could use self._attr_unique_id in __init__ but self.type is set after the parent's __init__ is called.

bdraco added 2 commits

March 13, 2023 13:15


          Memorize unique id

80b4ebc


          Slugify once instead of every state write

1e4f28f

bdraco changed the title ~~Memorize unique id~~ fix: memorize unique id

bdraco marked this pull request as ready for review

March 13, 2023 23:22

Owner

alandtse commented Mar 14, 2023

Thanks. And just FYI, the technical term is memoize, not memorize. ;)

alandtse merged commit 05f1689 into alandtse:dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet