Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async_get_registry is deprecated in 2022.6, use async_get instead #217

Merged
merged 1 commit into from
May 28, 2022

Conversation

jasperslits
Copy link
Contributor

The call to async_get_registry in tesla_device.py gives a deprecation warning in 2022.6b0, this PR changes the async call to async_get.
This should work for 2022.5.x too but haven't been able to test that.

@alandtse
Copy link
Owner

Thank you. Do you know if this change also means we have to bump our min version of HA? https://github.com/alandtse/tesla/blob/dev/hacs.json#L14

CI failure isn't related to your PR, so I'm ok with ignoring that for now.

@jasperslits
Copy link
Contributor Author

I don’t believe the bump is needed. It now just shows a warning but I don’t see anything on the removal. I think it typically takes another 2 releases at least.

@alandtse
Copy link
Owner

Oh, I meant whether you know if the async_get call exists in the older version of HA or not. This way we don't break people on older versions because we just enforce a minimum HA version.

@jasperslits
Copy link
Contributor Author

Oh, I meant whether you know if the async_get call exists in the older version of HA or not. This way we don't break people on older versions because we just enforce a minimum HA version.

I couldn't find the original commit, but it's been there for 15+ months: https://github.com/home-assistant/core/blame/dev/homeassistant/helpers/entity_registry.py

@alandtse
Copy link
Owner

Thanks. For future reference, if you can find the commit that brings it in, that will give you a list of all the HA versions that are supported.
home-assistant/core@ed31cc3

In this case, we're still supported. Thanks for checking and for the PR!

@alandtse alandtse merged commit f82e030 into alandtse:dev May 28, 2022
@jasperslits jasperslits deleted the entity_registry branch May 28, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants