Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match Devices to the same VIN. #208

Merged
merged 4 commits into from
May 2, 2022
Merged

Match Devices to the same VIN. #208

merged 4 commits into from
May 2, 2022

Conversation

Megabytemb
Copy link
Contributor

When we are updating other devices, we need to ensure we do so on the same device on the same car.

Fixes #207

@rako77
Copy link

rako77 commented May 2, 2022

thanks for this, I did find that the heated steering wheel switch hasn't been updated to include the vin.

await wait_for_climate(self.hass, self.config_entry_id)

@Megabytemb
Copy link
Contributor Author

Good spot.
Updated.

I'm working on a complete re-write of the entity handing in this component- https://github.com/megabytemb/tesla/tree/tesla-rewrite
I'll do my best to have complete test coverage to prevent issues like missed params like that.

@alandtse
Copy link
Owner

alandtse commented May 2, 2022

Thanks. I'll merge and release as soon as I get confirmation this fixes the issue. @rako77

@rako77
Copy link

rako77 commented May 2, 2022

Thank you, Confirmed working with my home setup, thank you so much.

@alandtse alandtse merged commit 5c81955 into alandtse:dev May 2, 2022
alandtse added a commit that referenced this pull request May 2, 2022
fix: check vin before adjusting climate devices (#208)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when multiple cars are tied to the same tesla account (heated steering and seats)
3 participants