Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when multiple cars are tied to the same tesla account (heated steering and seats) #207

Closed
rako77 opened this issue May 1, 2022 · 4 comments · Fixed by #208
Closed
Labels
bug Something isn't working

Comments

@rako77
Copy link

rako77 commented May 1, 2022

async def get_device(

In this helper and specifically my issue is with an account with multiple cars fails to turn on the correct climate when enabling the heated steering wheel or heated seats.

The issue appears to be it's returning the first device in the array of devices without checking that the device is the right one, therefor In my home when the heated steering for Car # 2 is triggered it turns on Car # 1 climate.

@alandtse alandtse added the bug Something isn't working label May 2, 2022
@alandtse
Copy link
Owner

alandtse commented May 2, 2022

@Megabytemb @ehendrix23 can either of you confirm please?

@Megabytemb
Copy link
Contributor

I wish i had the infrastructure to properly test this. haha
But i can see how that problem would arise.

I don't know exactly how I would fix it right now, But i'll get this done after work (or perhaps at lunch) today.

@ehendrix23
Copy link
Contributor

@Megabytemb Let me know if you need help. I have 2 cars in my account. Only 1 with heater steering wheel but both have heated seats. :-)

@Megabytemb
Copy link
Contributor

Created #208 which i believe fixes this issue.

alandtse pushed a commit that referenced this issue May 2, 2022
Fixes bug where the wrong seat heater or steering wheel heater was impacted for accounts with multiple vehicles.

Fixes #207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants