-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
projectField not working on data with non-dimension coordinates in latest xarray version #123
Comments
Hi @DangoMelon, thanks for your interest. I have not been able to maintain the xarray interface recently, if you would like to fix this with a pull request I'd be happy to review. |
Thanks for the reply! I will send a PR with said change now. |
I just encountered this same error. Thanks so much @DangoMelon for making a PR to fix it! |
I also encountered this error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
xarray
released a few days ago the 0.19.0 version which comes with some deprecations (pydata/xarray#5630) that seem to affect data with non-dimension coordinate only.Sample code
This is the error raised
Changing the last line to
fixes the issue, however a non-dimension coordinate is lost, being in this case the coordinate 'month' that comes from the groupby operation from
xarray
.Testing the same sample code with the previous
xarray
version (0.18.2) yields the expected resultFollowing the suggestion in the error raised by changing this line
eofs/lib/eofs/xarray.py
Lines 638 to 640 in 603ed8e
to
Solves the issue with no apparent breaking change. I can send a simple PR if it seems okey.
The text was updated successfully, but these errors were encountered: