[Fix] debug: print String objects as strings

enzymejs · Dec 22, 2017 · 8533b5e · 8533b5e
1 parent 5b5439a
commit 8533b5e
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/packages/enzyme-test-suite/package.json b/packages/enzyme-test-suite/package.json
@@ -49,4 +49,4 @@
     "eslint-plugin-jsx-a11y": "^6.0.3",
     "eslint-plugin-react": "^7.5.1"
   }
-}
+}
diff --git a/packages/enzyme-test-suite/test/Debug-spec.jsx b/packages/enzyme-test-suite/test/Debug-spec.jsx
@@ -202,6 +202,11 @@ describe('debug', () => {
       ))).to.equal('<div id="foo" />');
     });
 
+    it('should render a boxed String object as a string', () => {
+      expect(debugElement((
+        <div className={Object('foo')} />
+      ))).to.equal('<div className="foo" />');
+    });
   });
 
   describeWithDOM('debugInst(inst)', () => {

diff --git a/packages/enzyme/package.json b/packages/enzyme/package.json
@@ -37,6 +37,7 @@
     "cheerio": "^1.0.0-rc.2",
     "function.prototype.name": "^1.0.3",
     "has": "^1.0.1",
+    "is-string": "^1.0.4",
     "is-subset": "^0.1.1",
     "lodash": "^4.17.4",
     "object-is": "^1.0.1",

diff --git a/packages/enzyme/src/Debug.js b/packages/enzyme/src/Debug.js
@@ -2,6 +2,7 @@ import without from 'lodash/without';
 import escape from 'lodash/escape';
 import compact from 'lodash/compact';
 import functionName from 'function.prototype.name';
+import isString from 'is-string';
 
 import {
   propsOfNode,
@@ -32,6 +33,9 @@ function propString(prop) {
     case 'boolean':
       return `{${prop}}`;
     case 'object':
+      if (isString(prop)) {
+        return `"${prop}"`;
+      }
       return '{{...}}';
     default:
       return `{[${typeof prop}]}`;