This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Make getModeForRange() behave like getModeForSelection() when mode is not mixed #7775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, I tested C++ (line and block comments) and bash (line comments) and they seem to work fine with this fix. |
|
Looks good to me. This keeps the master behavior when #7345 remains to track a larger, longer-term cleanup. Our APIs are very inconsistent and ambiguous right now about when "mode" means the CM base mode name vs. the mimetype string vs. a mode object with config properties. |
peterflynn
added a commit
that referenced
this pull request
May 7, 2014
Make getModeForRange() behave like getModeForSelection() when mode is not mixed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7764. This isn't the cleanest fix, but it exactly preserves the existing behavior for the case where
getModeForRange()is called fromgetModeForSelection(), while fixing the behavior for the case wheregetModeForRange()is called directly from the commenting operations in EditorCommandHandlers.The EditorCommandHandlers unit tests all pass with this fix.
@peterflynn /cc @TomMalbran