Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Themes in Brackets core #7616

Closed
wants to merge 82 commits into from
Closed

Themes in Brackets core #7616

wants to merge 82 commits into from

Commits on Apr 24, 2014

  1. Initial commit to integrate themes into brackets core

    @MiguelCastillo
    MiguelCastillo committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    d12d87b View commit details
    Browse the repository at this point in the history

  2. Delete stale Init.js file

    @MiguelCastillo
    MiguelCastillo committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    657df85 View commit details
    Browse the repository at this point in the history

  3. Cleaned up jslint errors/warnings

    @MiguelCastillo
    MiguelCastillo committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    5cb4085 View commit details
    Browse the repository at this point in the history

  4. Removed string.js. Not needed anymore

    @MiguelCastillo
    MiguelCastillo committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    abf3e49 View commit details
    Browse the repository at this point in the history

  5. Removed custom themes from the themes extension

    @MiguelCastillo
    MiguelCastillo committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    5473380 View commit details
    Browse the repository at this point in the history

  6. Cleaned up extra white spaces

    @MiguelCastillo
    MiguelCastillo committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    a1dea7e View commit details
    Browse the repository at this point in the history

  7. Adjusted comments to follow convention

    @MiguelCastillo
    MiguelCastillo committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    6f1df7a View commit details
    Browse the repository at this point in the history

  8. Adding CMD_THEMES to nls strings.js

    @MiguelCastillo
    MiguelCastillo committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    361d715 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2014

  1. Checking support to load themes as extensions 

    This works by checking if the “theme” field exists in the package.json
to determine if the extension ought to be treated as a theme or not.
    @MiguelCastillo
    MiguelCastillo committed Apr 26, 2014
    Configuration menu
    Copy the full SHA
    7a8997f View commit details
    Browse the repository at this point in the history

  2. Refactored ExtensionLoader so that it can preload package.json 

    So that we can preemptively figure out if the extension is a theme or a
regular extension.
    @MiguelCastillo
    MiguelCastillo committed Apr 26, 2014
    Configuration menu
    Copy the full SHA
    2856006 View commit details
    Browse the repository at this point in the history

  3. Removed logic to load CodeMirror themes automatically

    @MiguelCastillo
    MiguelCastillo committed Apr 26, 2014
    Configuration menu
    Copy the full SHA
    b0df2fc View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2014

  1. themes settings css and html files to their styles and htmlContent co… 

    …rresponding folders.
    @MiguelCastillo
    MiguelCastillo committed Apr 27, 2014
    Configuration menu
    Copy the full SHA
    1c64c1a View commit details
    Browse the repository at this point in the history

  2. Renames settings.js to settingsmanager.js

    @MiguelCastillo
    MiguelCastillo committed Apr 27, 2014
    Configuration menu
    Copy the full SHA
    a572d22 View commit details
    Browse the repository at this point in the history

  3. Moved views/settings to ThemeSettingsDialog

    @MiguelCastillo
    MiguelCastillo committed Apr 27, 2014
    Configuration menu
    Copy the full SHA
    e68c3ec View commit details
    Browse the repository at this point in the history

  4. Removed paths from settings. That's ole stuff from themes extension

    @MiguelCastillo
    MiguelCastillo committed Apr 27, 2014
    Configuration menu
    Copy the full SHA
    43b5abb View commit details
    Browse the repository at this point in the history

  5. Changed (void 0) checks to undefined.

    @MiguelCastillo
    MiguelCastillo committed Apr 27, 2014
    Configuration menu
    Copy the full SHA
    92ac359 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/master'

    @MiguelCastillo
    MiguelCastillo committed Apr 27, 2014
    Configuration menu
    Copy the full SHA
    fb54d2f View commit details
    Browse the repository at this point in the history

  7. Removed obsolete files

    @MiguelCastillo
    MiguelCastillo committed Apr 27, 2014
    Configuration menu
    Copy the full SHA
    bc7054f View commit details
    Browse the repository at this point in the history

  8. Change exports.THEMES to exports.CMD_THEMES_SETTINGS_OPEN

    @MiguelCastillo
    MiguelCastillo committed Apr 27, 2014
    Configuration menu
    Copy the full SHA
    767c9e5 View commit details
    Browse the repository at this point in the history

  9. Renamed view export from CMD_THEMES_SETTINGS_OPEN to CMD_THEMES_OPEN_… 

    …SETTINGS
    @MiguelCastillo
    MiguelCastillo committed Apr 27, 2014
    Configuration menu
    Copy the full SHA
    5c6f83b View commit details
    Browse the repository at this point in the history

Commits on May 6, 2014

  1. Removing license file as its no longer needed due to CLA

    @MiguelCastillo
    MiguelCastillo committed May 6, 2014
    Configuration menu
    Copy the full SHA
    d83bf29 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2014

  1. Enabling the use of the package title to be the primary source of the… 

    … theme name
    @MiguelCastillo
    MiguelCastillo committed May 7, 2014
    Configuration menu
    Copy the full SHA
    0854441 View commit details
    Browse the repository at this point in the history

  2. Big refactor to make use of definePreference and rely on its change e… 

    …vents
    @MiguelCastillo
    MiguelCastillo committed May 7, 2014
    Configuration menu
    Copy the full SHA
    f9d29db View commit details
    Browse the repository at this point in the history

Commits on May 8, 2014

  1. Reading text files with FileUtils.readAsText

    @MiguelCastillo
    MiguelCastillo committed May 8, 2014
    Configuration menu
    Copy the full SHA
    d55254f View commit details
    Browse the repository at this point in the history

  2. Change to use FileUtils.getFileExtension

    @MiguelCastillo
    MiguelCastillo committed May 8, 2014
    Configuration menu
    Copy the full SHA
    f686926 View commit details
    Browse the repository at this point in the history

  3. Exposing theme change event and loadDirectory interface

    @MiguelCastillo
    MiguelCastillo committed May 8, 2014
    Configuration menu
    Copy the full SHA
    02515b1 View commit details
    Browse the repository at this point in the history

  4. Moved CodeMirrorAddons from themes to a global module that brackets uses

    @MiguelCastillo
    MiguelCastillo committed May 8, 2014
    Configuration menu
    Copy the full SHA
    e037fc0 View commit details
    Browse the repository at this point in the history

  5. Removed loadList to clean up the code a bit. Also renamed ThemeFiles.… 

    …js to FileLoader.js
    @MiguelCastillo
    MiguelCastillo committed May 8, 2014
    Configuration menu
    Copy the full SHA
    8ee527b View commit details
    Browse the repository at this point in the history

  6. Fixed issue with selected theme not properly getting select in the se… 

    …ttings dialog
    @MiguelCastillo
    MiguelCastillo committed May 8, 2014
    Configuration menu
    Copy the full SHA
    fe05d09 View commit details
    Browse the repository at this point in the history

  7. Setting themes up so that it can support mixing themes if we were to … 

    …enable multi select
    @MiguelCastillo
    MiguelCastillo committed May 8, 2014
    Configuration menu
    Copy the full SHA
    f8eac83 View commit details
    Browse the repository at this point in the history

  8. Added logic to handle correctly setting selected state when selecting… 

    … multiple themes
    @MiguelCastillo
    MiguelCastillo committed May 8, 2014
    Configuration menu
    Copy the full SHA
    1ba4ac0 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2014

  1. Removed mark-selection add-on. Will add this in a different PR. Also … 

    …removed default settings from CodeMirrorAddon.js
    @MiguelCastillo
    MiguelCastillo committed May 9, 2014
    Configuration menu
    Copy the full SHA
    5bd2d89 View commit details
    Browse the repository at this point in the history

  2. Removed require CodeMirror as its no longer needed

    @MiguelCastillo
    MiguelCastillo committed May 9, 2014
    Configuration menu
    Copy the full SHA
    e46a93d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' 

    Conflicts:
	src/brackets.js
    @MiguelCastillo
    MiguelCastillo committed May 9, 2014
    Configuration menu
    Copy the full SHA
    b2d0702 View commit details
    Browse the repository at this point in the history

  4. Added I18 string support to the dialog

    @MiguelCastillo
    MiguelCastillo committed May 9, 2014
    Configuration menu
    Copy the full SHA
    768d2f0 View commit details
    Browse the repository at this point in the history

  5. Corrected comment and some formatting in string.js

    @MiguelCastillo
    MiguelCastillo committed May 9, 2014
    Configuration menu
    Copy the full SHA
    2c74247 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2014

  1. Merge remote-tracking branch 'upstream/master'

    @MiguelCastillo
    MiguelCastillo committed May 16, 2014
    Configuration menu
    Copy the full SHA
    a1f6c6a View commit details
    Browse the repository at this point in the history

Commits on May 23, 2014

  1. Merge remote-tracking branch 'upstream/master'

    @MiguelCastillo
    MiguelCastillo committed May 23, 2014
    Configuration menu
    Copy the full SHA
    bce17ad View commit details
    Browse the repository at this point in the history

Commits on May 29, 2014

  1. Major rewrite to move code around to be more inline with Brackets cor… 

    …e code
    @MiguelCastillo
    MiguelCastillo committed May 29, 2014
    Configuration menu
    Copy the full SHA
    9832add View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master'

    @MiguelCastillo
    MiguelCastillo committed May 29, 2014
    Configuration menu
    Copy the full SHA
    6cf0eae View commit details
    Browse the repository at this point in the history

  3. Fixed issue with unnecessary reload of themes when opening a new docu… 

    …ment
    @MiguelCastillo
    MiguelCastillo committed May 29, 2014
    Configuration menu
    Copy the full SHA
    803c26f View commit details
    Browse the repository at this point in the history

  4. Chages to remove extra white spaces in expressions to follow Brackets… 

    … coding style guidelines
    @MiguelCastillo
    MiguelCastillo committed May 29, 2014
    Configuration menu
    Copy the full SHA
    fc498a8 View commit details
    Browse the repository at this point in the history

  5. Merge general settings and theme settings because there is only one t… 

    …ab in there. No need for single tabbed views
    @MiguelCastillo
    MiguelCastillo committed May 29, 2014
    Configuration menu
    Copy the full SHA
    796322a View commit details
    Browse the repository at this point in the history

  6. Another style change

    @MiguelCastillo
    MiguelCastillo committed May 29, 2014
    Configuration menu
    Copy the full SHA
    2f94472 View commit details
    Browse the repository at this point in the history

  7. Moving code mirror add ons back to brackets.js

    @MiguelCastillo
    MiguelCastillo committed May 29, 2014
    Configuration menu
    Copy the full SHA
    ff3c065 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2014

  1. Moved Theme to ThemeManager

    @MiguelCastillo
    MiguelCastillo committed May 31, 2014
    Configuration menu
    Copy the full SHA
    ab93c01 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2014

  1. Corrected issue with documents not getting properly styles with a theme

    @MiguelCastillo
    MiguelCastillo committed Jun 1, 2014
    Configuration menu
    Copy the full SHA
    1d81228 View commit details
    Browse the repository at this point in the history

  2. Removed force reload when appReady is resolved

    @MiguelCastillo
    MiguelCastillo committed Jun 1, 2014
    Configuration menu
    Copy the full SHA
    8d94e86 View commit details
    Browse the repository at this point in the history

  3. Refactored ThemeManager to merge several functions to make the code a… 

    … bit more readable.
    @MiguelCastillo
    MiguelCastillo committed Jun 1, 2014
    Configuration menu
    Copy the full SHA
    7834318 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2014

  1. Added documentation to ThemeManager.js

    @MiguelCastillo
    MiguelCastillo committed Jun 2, 2014
    Configuration menu
    Copy the full SHA
    280c83e View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2014

  1. Adding comment I mistakenly changed

    @MiguelCastillo
    MiguelCastillo committed Jun 3, 2014
    Configuration menu
    Copy the full SHA
    72f6354 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2014

  1. Fixed issue where themes that no longer existed would cause the theme… 

    … loader to completely fail. Also Added better handling for theme names that's not strictly based on the name of the file
    @MiguelCastillo
    MiguelCastillo committed Jun 5, 2014
    Configuration menu
    Copy the full SHA
    43ed137 View commit details
    Browse the repository at this point in the history

  2. Removed temp code to load all code mirror themes

    @MiguelCastillo
    MiguelCastillo committed Jun 5, 2014
    Configuration menu
    Copy the full SHA
    1c05805 View commit details
    Browse the repository at this point in the history

  3. Fixed issue with theme not being applied when set while no documents … 

    …were open
    @MiguelCastillo
    MiguelCastillo committed Jun 5, 2014
    Configuration menu
    Copy the full SHA
    ea1aab0 View commit details
    Browse the repository at this point in the history

  4. Remove old css file to avoid weird flashes when saving a theme

    @MiguelCastillo
    MiguelCastillo committed Jun 5, 2014
    Configuration menu
    Copy the full SHA
    1416cd9 View commit details
    Browse the repository at this point in the history

  5. Adjusted code mirror override to allow for themes to override the def… 

    …ined styling tokens
    @MiguelCastillo
    MiguelCastillo committed Jun 5, 2014
    Configuration menu
    Copy the full SHA
    8bfd51e View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2014

  1. Adding initial default themes. Thor Dark and Thor Light

    @MiguelCastillo
    MiguelCastillo committed Jun 6, 2014
    Configuration menu
    Copy the full SHA
    ef8b5cd View commit details
    Browse the repository at this point in the history

  2. Added importance to make sure cursor is visible when it is on the lef… 

    …t side of a matching bracket/parenthesis
    @MiguelCastillo
    MiguelCastillo committed Jun 6, 2014
    Configuration menu
    Copy the full SHA
    2c06fd2 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' 

    Conflicts:
	src/brackets.js
    @MiguelCastillo
    MiguelCastillo committed Jun 6, 2014
    Configuration menu
    Copy the full SHA
    c38e68d View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2014

  1. Merge remote-tracking branch 'upstream/master'

    @MiguelCastillo
    MiguelCastillo committed Jun 7, 2014
    Configuration menu
    Copy the full SHA
    79f7350 View commit details
    Browse the repository at this point in the history

  2. Removed stale general.html file

    @MiguelCastillo
    MiguelCastillo committed Jun 7, 2014
    Configuration menu
    Copy the full SHA
    aebe379 View commit details
    Browse the repository at this point in the history

  3. Fixed issues in CM override less file that's breaking the build

    @MiguelCastillo
    MiguelCastillo committed Jun 7, 2014
    Configuration menu
    Copy the full SHA
    8cef24a View commit details
    Browse the repository at this point in the history

  4. Fixed issue where themes aren't properly reloaded when modified

    @MiguelCastillo
    MiguelCastillo committed Jun 7, 2014
    Configuration menu
    Copy the full SHA
    710d4e0 View commit details
    Browse the repository at this point in the history

  5. Removed leftover console.log statement

    @MiguelCastillo
    MiguelCastillo committed Jun 7, 2014
    Configuration menu
    Copy the full SHA
    9894c0e View commit details
    Browse the repository at this point in the history

  6. Fixed issue with document types not properly cleaned up from the DOM.… 

    … Also, document type is now going in the body element to enable styling per document type
    @MiguelCastillo
    MiguelCastillo committed Jun 7, 2014
    Configuration menu
    Copy the full SHA
    72f5f34 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2014

  1. Reverted back tune up changes in codemirror-override. Will do another… 

    … pass a bit later
    @MiguelCastillo
    MiguelCastillo committed Jun 8, 2014
    Configuration menu
    Copy the full SHA
    57df196 View commit details
    Browse the repository at this point in the history

  2. Added rootpath to handle imports defined in styles/brackets*.less fil… 

    …es. This also allows for handling of other imports relative to the theme itself.
    @MiguelCastillo
    MiguelCastillo committed Jun 8, 2014
    Configuration menu
    Copy the full SHA
    7f5a33c View commit details
    Browse the repository at this point in the history

  3. Tweaked darkt theme and removed #status-overwrite text color that int… 

    …erfered with theming.
    Larz authored and Larz committed Jun 8, 2014
    Configuration menu
    Copy the full SHA
    d71bbcb View commit details
    Browse the repository at this point in the history

  4. Using default Brackets theme as default light theme.

    Larz authored and Larz committed Jun 8, 2014
    Configuration menu
    Copy the full SHA
    cdfa4be View commit details
    Browse the repository at this point in the history

  5. More dark theme tweaks.

    Larz authored and Larz committed Jun 8, 2014
    Configuration menu
    Copy the full SHA
    1491ad3 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #1 from MiguelCastillo/larz/theme-tweaks 

    Theme Tweaks - There you go, this is more like it!
    @MiguelCastillo
    MiguelCastillo committed Jun 8, 2014
    Configuration menu
    Copy the full SHA
    9188e5c View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2014

  1. Removed extra call the get promise object. Redundant.

    @MiguelCastillo
    MiguelCastillo committed Jun 17, 2014
    Configuration menu
    Copy the full SHA
    22fc569 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2014

  1. Removed stale dependency

    @MiguelCastillo
    MiguelCastillo committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    67abe19 View commit details
    Browse the repository at this point in the history

  2. Added a default to be loaded when the current theme isn't available. … 

    …This cleaned up the rejected promises being returned. Fixed issue in loadCurrentTheme incorrect $.when call. Cleaned up a few other small issues
    @MiguelCastillo
    MiguelCastillo committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    e14f151 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' 

    Conflicts:
	src/nls/root/strings.js
	src/styles/brackets_codemirror_override.less
    @MiguelCastillo
    MiguelCastillo committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    d302434 View commit details
    Browse the repository at this point in the history

  4. Export reset settings interface and set the default theme to thor-lig… 

    …ht-theme
    @MiguelCastillo
    MiguelCastillo committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    31cb2a6 View commit details
    Browse the repository at this point in the history

  5. Changed loop for iterating through new settings. Feedback from Kevin

    @MiguelCastillo
    MiguelCastillo committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    b6a7ef3 View commit details
    Browse the repository at this point in the history

  6. Cleaned up a bit of the logic for selecting themes in the event handl… 

    …er for the settings UI
    @MiguelCastillo
    MiguelCastillo committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    86f78eb View commit details
    Browse the repository at this point in the history

  7. Cleaned up some of the comments and stale variables

    @MiguelCastillo
    MiguelCastillo committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    a102a51 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2014

  1. Merge remote-tracking branch 'upstream/master'

    @MiguelCastillo
    MiguelCastillo committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    0ce29ce View commit details
    Browse the repository at this point in the history

  2. Removing extra promise call

    @MiguelCastillo
    MiguelCastillo committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    c2d26f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2014

  1. Conflict resolution for CodeMirror

    @MiguelCastillo
    MiguelCastillo committed Jun 29, 2014
    Configuration menu
    Copy the full SHA
    8f2619f View commit details
    Browse the repository at this point in the history