Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

fix as suggested in #7333 #7599

Merged
merged 1 commit into from
Apr 23, 2014
Merged

fix as suggested in #7333 #7599

merged 1 commit into from
Apr 23, 2014

Conversation

zaggino
Copy link
Contributor

@zaggino zaggino commented Apr 22, 2014

No description provided.

@zaggino
Copy link
Contributor Author

zaggino commented Apr 22, 2014

cc @RaymondLim @hpoom

@marcelgerber
Copy link
Contributor

Well, I'm not sure whether root should be changed to English (US) - it's used for other English speaking countries (Australia, Canada) as well (and of course it's the main fallback).

@hpoom
Copy link

hpoom commented Apr 22, 2014

@zaggino Like the fix, thanks. Should have coded it myself, next time.

@SAplayer I think English (US) is OK, I would even go so far to suggest LOCALE_EN should be LOCALE_EN_US. When you see how other software and organisations deal with this, calling the it en-us is standard. I accept that other countries speak this variation of English, but most other software still calls it en-us.

See Firefox as an example:
http://www.mozilla.org/en-US/firefox/all/
On that pages there is English (British), English (South African) and English (US). In the configs it is en-GB, en-ZA and en-US

Chrome is similar, they call it English (United States).

I think we are best to change Brackets to be inline with the conventions set by other software and to adhere as closely as possible to the ISO standards.

@zaggino
Copy link
Contributor Author

zaggino commented Apr 22, 2014

Australia & Canada (and a lot of former colonies) use British English so I don't think we need to add more than US & UK. Only question for me is if it should be US & UK or United States & British or whatever should be displayed for the end user. It seems every software uses different terms here (British in Firefox vs United Kingdom in Chrome)

@RaymondLim
Copy link
Contributor

I think US & UK are perfectly fine. @SAplayer Showing English (US) for root is better when we have English (UK) showing in the list.

@RaymondLim
Copy link
Contributor

LGTM. Merging.

RaymondLim added a commit that referenced this pull request Apr 23, 2014
@RaymondLim RaymondLim merged commit 7e0d04d into master Apr 23, 2014
@RaymondLim RaymondLim deleted the fix-7333 branch April 23, 2014 04:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants