Help menu changes, version 2 #7410
Conversation
…e and the new Suggest a Feature page.
| "CMD_RELEASE_NOTES" : "Release Notes", | ||
| "CMD_REPORT_AN_ISSUE" : "Report an Issue", | ||
| "CMD_GET_INVOLVED" : "Hacking on Brackets", |
There was a problem hiding this comment.
I know we're just reverting this but it seems like an opportunity to change the menu item to "Get Involved" which sounds a little more immersive and personal than "Hacking on Brackets". "Get Involved" may intrigue more folks into actually getting involved which is nice...
There was a problem hiding this comment.
Sure, we can try that. I wasn't sure initially if Get Involved would be as clear.
|
We should think about how these changes map onto other flavors like Edge Code, too. Does the forum menu item need to stick around for that reason, for example? Or I guess the support menu item would map onto that? |
|
Yeah, I think the support menu item would point to the forum for Edge Code. |
|
Changes pushed. |
| @@ -346,9 +346,10 @@ define({ | |||
| "HELP_MENU" : "Help", | |||
| "CMD_CHECK_FOR_UPDATE" : "Check for Updates", | |||
| "CMD_HOW_TO_USE_BRACKETS" : "How to Use {APP_NAME}", | |||
| "CMD_FORUM" : "{APP_NAME} Forum", | |||
| "CMD_SUPPORT" : "Support for Using {APP_NAME}", | |||
There was a problem hiding this comment.
This feels a little "wordy" and syntactically awkward grammar-wise. Can we just shorten it to "Troubleshooting" since the page that it links to actually is the "Troubleshooting guide".
Says so right in the title :)
There was a problem hiding this comment.
In other distributions it might be something else -- for example, for Edge Code it would link to the support forum.
There was a problem hiding this comment.
@peterflynn We can't have different strings for Edge Code and Brackets for this menu item?
There was a problem hiding this comment.
That's fair, presumably we could. I'll defer to whatever @dangoor thinks makes sense.
There was a problem hiding this comment.
I prefer Support to Troubleshooting because I think it's really more about
answering users' questions than troubleshooting. It will often be
troubleshooting, but not always. (If anything, I'd be more of the opinion
of changing the page title on GitHub, but I see no reason to do that now...
and the page title is a small thing.)
On Friday, April 4, 2014, Peter Flynn notifications@github.com wrote:
In src/nls/root/strings.js:
@@ -346,9 +346,10 @@ define({
"HELP_MENU" : "Help",
"CMD_CHECK_FOR_UPDATE" : "Check for Updates",
"CMD_HOW_TO_USE_BRACKETS" : "How to Use {APP_NAME}",
- "CMD_FORUM" : "{APP_NAME} Forum",
- "CMD_SUPPORT" : "Support for Using {APP_NAME}",
That's fair, presumably we could. I'll defer to whatever @dangoorhttps://github.com/dangoorthinks makes sense.
Reply to this email directly or view it on GitHubhttps://github.com//pull/7410/files#r11311331
.
|
@dangoor you could do |
|
@JeffryBooher "Support for Using Brackets" doesn't sound like a pledge drive, and that's the string the PR currently has. But I agree "Brackets Support" sounds a little nicer nonetheless. What do you mean about templatizing though? The string in this PR is already using |
|
... as opposed to using two different strings for Brackets and Edge Code. |
|
I'm afk for the evening... I'm fine with APP_NAME Support On Friday, April 4, 2014, Peter Flynn notifications@github.com wrote:
|
|
I can make the change and merge it. |
|
Looks good all tests pass but I ran into #7420 which seems like a recent thing but this also occurs in master and running all integration tests on the Mac is not a problem. Also running the failed tests again individually is ok. ...merging |
Help menu changes, version 2
This reverts my previous revert and changes the links.