This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Restore original selection behavior and fix up unit tests for recent CM change #7214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge to primary selection default
|
@redmunds - should merge this soon to fix the unit tests - sorry I didn't run them before I pushed the new SHA... |
|
Reviewing |
|
Merging. |
redmunds
added a commit
that referenced
this pull request
Mar 17, 2014
Restore original selection behavior and fix up unit tests for recent CM change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, CodeMirror's
setSelections()defaulted to always using the last selection passed if no primary selection index was specified.codemirror/codemirror5@00e4259 changed it so the default is to use the index of the primary selection from whatever the previous selection was.
I commented on that commit that I'm not sure that was the right change, but I think it's arguable. In any case, this commit fixes things to restore our previous behavior:
primIndexto the last item in the selection if no primary selection is specified.