This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Add origin parameter to setSelection()/setSelections() #7196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing "review only" tag - I think we should go ahead and merge this even though it doesn't fix #7182, since it exposes CM functionality that's analogous to the functionality we already expose in |
|
@njx Yep, this fixes it for everyscrub |
|
Oh really? You didn't need to wrap it in an operation? |
|
Ah - apparently it was working for * origins but not + origins (which is what I had tested). Marijn has fixed that in a later patch. |
|
FYI, the fix to this for + origins has also landed. |
|
@redmunds - could you review this one? |
|
Ah, yeah -- everyscrub uses *. And yes, it worked without needing to wrap it in a batch. |
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Mar 19, 2014
Add origin parameter to setSelection()/setSelections()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peterflynn - try this and see if setting an origin in your selection code in everyscrub now merges properly again without having to wrap it in an operation with the replaceRange.
Addresses #7182.