Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix chrome launching problems #3098

Merged
merged 3 commits into from
Mar 14, 2013
Merged

Fix chrome launching problems #3098

merged 3 commits into from
Mar 14, 2013

Conversation

redmunds
Copy link
Contributor

This is for #2370

This changes Brackets to always set enableRemoteDebugging to true. This only seems to effect Windows, but it's changed for both Mac and Windows, so both should be tested.

There is an associated randy/starting-live-dev branch on brackets-shell.

@gruehle - there is a remaining issue that @DennisKehrig had on WinXP where he reported that his default browser was forced to be Chrome. I was prompted to change default browser on Win7, so I asked him to double-check that this is a real issue.

@ghost ghost assigned gruehle Mar 12, 2013
@gruehle
Copy link
Member

gruehle commented Mar 12, 2013

@redmunds @DennisKehrig - These changes work fine for me on Win7 and Mac OSX 10.8. I'll wait to merge until I get the "all clear" on WinXP.

@redmunds
Copy link
Contributor Author

@peterflynn Since Dennis' hours are limited, can you give this a try on WinXP?

You need to use randy/starting-live-dev branches on both brackets and brackets-shell. Then try starting Live Dev in these cases:

  • Chrome closed
  • Chrome open with 1 or more open tabs opened by you
  • Chrome open with Dev Tools started from Brackets
  • Chrome open with Live Dev page (i.e. switching pages in Brackets)

Also test updating CSS and HTML in Brackets.

@redmunds
Copy link
Contributor Author

@peterflynn I forgot the most important test. Before you start, set your default browser to be something other than Chrome. Dennis reported that using Brackets Live Dev caused his default browser to change to Chrome, so I want to know if you can reproduce that.

@DennisKehrig
Copy link
Contributor

All Chromes closed: works. Crashed on exit once, but that seems to be the older, hard to reproduce bug.
My Chrome open: works, but ended up at file:// URL a couple of times
My Chrome open with Dev Tools started from Brackets: works
My Chrome open with 2x live dev page (file:// and http://): works
Brackets' Chrome open with 2x live dev page (file:// and http://): works, but changes the file:// tab to localhost instead of reusing the localhost one. The localhost tab is reused if the file:// one is not there, though.

@DennisKehrig
Copy link
Contributor

Changed appshell_extensions_win.cpp to use "--user-data-dir=brackets-profile2" - same thing as I said in my email: Chrome tries to import stuff from Firefox (and fails, presenting an error dialog that delays the process and causes Brackets to timeout if not dismissed soon enough), afterwards .html files open with Chrome if double-clicked.

Same thing with "--no-default-browser-check", sadly.
But "--no-first-run" solves it all: no import dialog, Firefox stays the default browser. :)

@redmunds
Copy link
Contributor Author

@DennisKehrig Thanks for testing and the solution! I added the --no-first-run flag to Windows code.

@gruehle Ready for another review.

@gruehle
Copy link
Member

gruehle commented Mar 14, 2013

Glad you got the first launch problem solved! Merging.

gruehle added a commit that referenced this pull request Mar 14, 2013
@gruehle gruehle merged commit 2550c37 into master Mar 14, 2013
@gruehle gruehle deleted the randy/starting-live-dev branch March 14, 2013 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants