-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
@redmunds @DennisKehrig - These changes work fine for me on Win7 and Mac OSX 10.8. I'll wait to merge until I get the "all clear" on WinXP. |
@peterflynn Since Dennis' hours are limited, can you give this a try on WinXP? You need to use randy/starting-live-dev branches on both brackets and brackets-shell. Then try starting Live Dev in these cases:
Also test updating CSS and HTML in Brackets. |
@peterflynn I forgot the most important test. Before you start, set your default browser to be something other than Chrome. Dennis reported that using Brackets Live Dev caused his default browser to change to Chrome, so I want to know if you can reproduce that. |
All Chromes closed: works. Crashed on exit once, but that seems to be the older, hard to reproduce bug. |
Changed appshell_extensions_win.cpp to use "--user-data-dir=brackets-profile2" - same thing as I said in my email: Chrome tries to import stuff from Firefox (and fails, presenting an error dialog that delays the process and causes Brackets to timeout if not dismissed soon enough), afterwards .html files open with Chrome if double-clicked. Same thing with "--no-default-browser-check", sadly. |
@DennisKehrig Thanks for testing and the solution! I added the --no-first-run flag to Windows code. @gruehle Ready for another review. |
Glad you got the first launch problem solved! Merging. |
This is for #2370
This changes Brackets to always set enableRemoteDebugging to true. This only seems to effect Windows, but it's changed for both Mac and Windows, so both should be tested.
There is an associated randy/starting-live-dev branch on brackets-shell.
@gruehle - there is a remaining issue that @DennisKehrig had on WinXP where he reported that his default browser was forced to be Chrome. I was prompted to change default browser on Win7, so I asked him to double-check that this is a real issue.