File Filters affect "Find In..."

[marcelgerber]

1. Open FindInFiles.js in the Brackets project (add it to the Working Files)
2. Invoke the context menu on the Working Files entry and click Find in...
3. Edit... the filter to contain src/search/FindInFiles.js
4. Start searching for, for example, Initial

Result: No results
Expected: Imo in this case, where the scope is just a single file, the filters shouldn't be active

[peterflynn]

That seems fair. For a subtree it's definitely still useful, but suppressing the filter for a single-file search makes sense to me.

[marcelgerber]

In a file tree, a filter affecting the whole scope should still not be used.

[peterflynn]

Well, there's only one filter you can edit right now. You might want a different filter when your search is specific to a certain subtree, just as you might want a different filter when you switch projects... but you can always edit the filter in that case. I don't think preemptively turning off all filtering abilities makes sense for subtree searches. Filtering is still very useful if the subtree is large.

By "affecting the whole scope" do you mean cases where the filter screens out every file in the selected subtree? We could give some sort of UI feedback in cases where 0 files pass the filter, so it's more clear what happened. (It actually might be useful in general to indicate how many or what percentage of the files in scope were searched vs. filtered out -- that's definitely a nice enhancement too).

[marcelgerber]

I'd like to see that enhancement as well.

But here's an example on what I meant:
Imagine this filter:

src/thirdparty

or this:

src/thirdparty/smart-auto-complete-local

Now Find in... src/thirdparty/smart-auto-complete-local/spec - you'll get no results 'cause the whole scope is ignored.

[peterflynn]

Reviewed - medium priority to me

[peterflynn]

@SAplayer The approach we decided on is threefold:

• When search scope is a single file, disable filtering and don't even show UI for it in the Find in Files bar
• When search scope + filter results in zero files to search, when you hit Enter we show a red error popup under the search field explaining this, and leave the search bar open so you can edit or remove the filter
• While editing a filter, we show a tally of how many files are included vs. excluded within the currently chosen search scope

[njx]

Closing as fixed - @SAplayer if you'd like to check it out in master, please let us know if you run into any issues.

[marcelgerber]

Works fine. Thanks.