You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
In LiveDevelopment.js loadAgents() function, agent names are synchronously added to the _loadedAgentNames array after calling agents[name].load(). Seems like they should only be in the list if the call to load() is resolved.
This does not seem to cause any known problem. It just seems to imply that it contains a list of successfully loaded agents and someone may try to use that for something in the future. Possible solutions:
If it simply contains the same list as _enabledAgentNames, then the _loadedAgentNames array is not needed
If the _loadedAgentNames array is needed, then it should be accurate.
The name should be changed to describe what's actually in the array.
The text was updated successfully, but these errors were encountered:
If any agent doesn't load, then Live Preview fails, so this isn't really an issue. The race condition mentioned by Ian was fixed with _loadAgentsPromise in PR #6889. Closing.
This was split off of pull #3203
In LiveDevelopment.js
loadAgents()
function, agent names are synchronously added to the_loadedAgentNames
array after callingagents[name].load()
. Seems like they should only be in the list if the call to load() is resolved.This does not seem to cause any known problem. It just seems to imply that it contains a list of successfully loaded agents and someone may try to use that for something in the future. Possible solutions:
_enabledAgentNames
, then the_loadedAgentNames
array is not needed_loadedAgentNames
array is needed, then it should be accurate.The text was updated successfully, but these errors were encountered: