Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Code Cleanup: Live Dev _loadedAgentNames is not accurate. #3390

Closed
redmunds opened this issue Apr 9, 2013 · 3 comments
Closed

Code Cleanup: Live Dev _loadedAgentNames is not accurate. #3390

redmunds opened this issue Apr 9, 2013 · 3 comments

Comments

@redmunds
Copy link
Contributor

redmunds commented Apr 9, 2013

This was split off of pull #3203

In LiveDevelopment.js loadAgents() function, agent names are synchronously added to the _loadedAgentNames array after calling agents[name].load(). Seems like they should only be in the list if the call to load() is resolved.

This does not seem to cause any known problem. It just seems to imply that it contains a list of successfully loaded agents and someone may try to use that for something in the future. Possible solutions:

  1. If it simply contains the same list as _enabledAgentNames, then the _loadedAgentNames array is not needed
  2. If the _loadedAgentNames array is needed, then it should be accurate.
  3. The name should be changed to describe what's actually in the array.
@pthiess
Copy link
Contributor

pthiess commented Apr 10, 2013

This would be a good thing for the community to look at, therefore I assign it at @dangoor but don't expect him to fix it by himself.

@jasonsanjose
Copy link
Member

Also see @iwehrman comment about possible race conditions in loadAgents/unloadAgents here #3203 (comment).

@redmunds
Copy link
Contributor Author

redmunds commented Mar 8, 2014

If any agent doesn't load, then Live Preview fails, so this isn't really an issue. The race condition mentioned by Ian was fixed with _loadAgentsPromise in PR #6889. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants