This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Migrate "fontSizeAdjustment" to new view states.
- Loading branch information
1 parent
ebb6b7a
commit 8d0abbd
Showing
2 changed files
with
30 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d0abbd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RaymondLim and @TomMalbran, I just selected this commit a bit arbitrarily because don't know exactly when this problem happened. The problem is the fontSizeChange event no longer fires off when I select Restore Font Size. It works fine for Increase Font Size and Decrease Font Size, but it appears to have been removed for Restore Font Size. It's breaking my Column Ruler extension.
8d0abbd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. When restoring the font size, we no longer call the adjust font size function which triggers the event. Should be easy to fix by addling trigger on the handle restore font code.
8d0abbd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomMalbran Do you want to submit a pr adding the trigger for restore font size function?
8d0abbd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RaymondLim and @TomMalbran, I got it: #7443